core, eth: fix tracer dirty finalization #16588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two tracer bugs:
statedb.Finalise
only do the cleanup, but not the expensive hash. The tracer's were never updated to use this new code, and the old legacy optimization/hack probably rotted away as noone was actively testing it. This PR gets rid of that legacy hack and uses the actual consensus code in the tracer too.Fixes #16582.