rpc: support returning nil pointer big.Ints (null) #16942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16925.
We replaced
big.Int
RPC handling in our codebase a long time ago with a custom type (hexutils.Big
). Almost all paths were updated to the new type, but a couple old invocations remained. These legacy cases couldn't cleanly handlenil
returns due to a convoluted way our legacy code handled hex encodings (reflect.Value().Interface()
) wrappings.