rpc: support returning nil pointer big.Ints (null) #16942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested changes
Jun 11, 2018
internal/ethapi/api.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return (*hexutil.Big)(price), nil |
There was a problem hiding this comment.
You can just return (*hexutil.Big)(price), err without the if.
rpc/utils.go
Outdated
| // to reliably catch these type issues otherwise. | ||
| if t.Name() == "Int" && t.PkgPath() == "math/big" { | ||
| panic(fmt.Sprintf("big.Int disallowed in RPC (%s)", method)) | ||
| } |
There was a problem hiding this comment.
I don't like this because the RPC server shouldn't be concerned with such details. Imagine documenting this: "This RPC server can be used for any API, but your methods may not return *big.Int".
There was a problem hiding this comment.
This was the only way I myself could ensure that we caught all API violations and didn't break anything (i.e. I only fixed getBalance and this mechanism caught the other 2-3 occurrences).
|
@fjl Fixed, PTAL. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16925.
We replaced
big.IntRPC handling in our codebase a long time ago with a custom type (hexutils.Big). Almost all paths were updated to the new type, but a couple old invocations remained. These legacy cases couldn't cleanly handlenilreturns due to a convoluted way our legacy code handled hex encodings (reflect.Value().Interface()) wrappings.