Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Change time format #17054

Merged
merged 1 commit into from
Jun 25, 2018
Merged

log: Change time format #17054

merged 1 commit into from
Jun 25, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 22, 2018

  • Keep the tailing zeros.
  • Limit precision to milliseconds.

Before:

INFO [06-22|10:37:33.009517] Imported new chain segment               blocks=22 txs=2803 mgas=161.955 elapsed=8.072s mgasps=20.062 number=5827911 hash=91cda6…962f91 cache=536.00mB
INFO [06-22|10:37:42.816757] Imported new chain segment               blocks=27 txs=3738 mgas=176.348 elapsed=9.807s mgasps=17.981 number=5827938 hash=b3336a…0db6ad cache=535.73mB
INFO [06-22|10:37:50.861573] Imported new chain segment               blocks=25 txs=3327 mgas=186.146 elapsed=8.044s mgasps=23.139 number=5827963 hash=665eb7…8521bf cache=535.55mB
INFO [06-22|10:37:59.14676] Imported new chain segment               blocks=21 txs=2913 mgas=158.204 elapsed=8.285s mgasps=19.095 number=5827984 hash=9f6d57…336535 cache=535.10mB
INFO [06-22|10:38:07.222425] Imported new chain segment               blocks=23 txs=2595 mgas=158.903 elapsed=8.075s mgasps=19.677 number=5828007 hash=939d52…e3cc54 cache=535.32mB
INFO [06-22|10:38:15.403928] Imported new chain segment               blocks=22 txs=2740 mgas=156.162 elapsed=8.181s mgasps=19.087 number=5828029 hash=f421b7…c32587 cache=535.11mB
INFO [06-22|10:38:23.482768] Imported new chain segment               blocks=18 txs=3173 mgas=132.471 elapsed=8.078s mgasps=16.397 number=5828047 hash=bb8e55…9fe23b cache=535.68mB

After:

INFO [06-22|10:48:32.367] Imported new chain segment               blocks=23 txs=3009 mgas=183.650 elapsed=9.494s    mgasps=19.343 number=5829188 hash=7005a6…07fa53 cache=151.08mB
INFO [06-22|10:48:40.662] Imported new chain segment               blocks=27 txs=3269 mgas=213.888 elapsed=8.294s    mgasps=25.785 number=5829215 hash=cd8ae1…b2f414 cache=157.64mB
INFO [06-22|10:48:48.785] Imported new chain segment               blocks=22 txs=2639 mgas=174.119 elapsed=8.123s    mgasps=21.435 number=5829237 hash=d05906…ea88af cache=162.66mB
INFO [06-22|10:48:56.876] Imported new chain segment               blocks=20 txs=2560 mgas=159.542 elapsed=8.091s    mgasps=19.718 number=5829257 hash=a2bbfb…e3ea15 cache=169.24mB
INFO [06-22|10:49:06.050] Imported new chain segment               blocks=23 txs=3177 mgas=168.945 elapsed=9.173s    mgasps=18.416 number=5829280 hash=3fa15c…e71407 cache=171.70mB
INFO [06-22|10:49:14.116] Imported new chain segment               blocks=28 txs=2934 mgas=184.112 elapsed=8.066s    mgasps=22.825 number=5829308 hash=5a8a32…5a12ca cache=173.19mB
INFO [06-22|10:49:22.166] Imported new chain segment               blocks=19 txs=2445 mgas=133.785 elapsed=8.049s    mgasps=16.620 number=5829327 hash=1cf532…05de75 cache=177.54mB
INFO [06-22|10:49:30.472] Imported new chain segment               blocks=20 txs=2383 mgas=149.456 elapsed=8.306s    mgasps=17.993 number=5829347 hash=4cd994…07ea55 cache=181.03mB
INFO [06-22|10:49:39.677] Imported new chain segment               blocks=25 txs=2748 mgas=172.918 elapsed=9.205s    mgasps=18.785 number=5829372 hash=7c96ab…c93c55 cache=184.53mB

@karalabe
Copy link
Member

I don't like the space change, it was more readable before. The millisecond fix is a good call!

- Keep the tailing zeros.
- Limit precision to milliseconds.
@chfast chfast force-pushed the log-time-format branch from 2fb2b13 to 6d8a1bf Compare June 25, 2018 09:22
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.8.12 milestone Jun 25, 2018
@karalabe karalabe merged commit b0cfd9c into ethereum:master Jun 25, 2018
@chfast
Copy link
Member Author

chfast commented Jun 25, 2018

Removed the space change.

@axic axic deleted the log-time-format branch April 24, 2019 09:36
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 14, 2024
- Keep the tailing zeros.
- Limit precision to milliseconds.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 14, 2024
- Keep the tailing zeros.
- Limit precision to milliseconds.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 14, 2024
- Keep the tailing zeros.
- Limit precision to milliseconds.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024
- Keep the tailing zeros.
- Limit precision to milliseconds.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024
- Keep the tailing zeros.
- Limit precision to milliseconds.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 15, 2024
- Keep the tailing zeros.
- Limit precision to milliseconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants