core/vm: first version of the intpool pool #17070

gballet · 2018-06-25T08:39:54Z

This PR is still WIP and is a RFC to @karalabe

gballet · 2018-06-25T08:41:16Z

core/vm/intpool.go

+		}
+	}
+
+	panic("Could not find a pool")


@karalabe What should happen if no extra pool can be allocated?

You can always allocate a new pool if there's none pending. You only store the available ones, don't pre-allocate and do arrays. No need, simple slice. If it's empty, you make a new one.

gballet · 2018-06-25T08:42:43Z

core/vm/intpool.go

+}
+
+// release a pool that has been allocated with Get
+func (ipp *IntPoolPool) release(ip *intPool) {


@karalabe I'm really not a fan of having to manually release pools. I could come up with a general release thing (for e.g. when a transaction has been processed). Interested in your input though.

Why? It's similar to mutex lock/unlock, to sync.pool get/out, to calling Close on almost everything.

But your mechanism is convoluted. Only use a single slice of pools, you can then fetch from there, or put back when you're done.

karalabe · 2018-06-25T08:54:23Z

core/vm/intpool.go

+	PoolPoolTypeTracer
+	PoolPoolTypeRPC
+	PoolPoolTypes
+)


I think you over complicated this. intPoolPool should only contain a []*intPool, which you programatically cap to about 5. There's no need to have dedicated pools for different subsystems.

The idea is to behave like sync.Pool, just to survive GC runs (which clear sync.Pool).

gballet · 2018-06-25T08:58:27Z

core/vm/intpool.go

+	locks [PoolPoolTypes]sync.RWMutex
+}
+
+var intPoolPool = IntPoolPool{}


@karalabe I would like to export this but I'm looking for a nicer name. Any idea?

don't export it. not even the type. It's a very specialized thing used by the vm, no need to surface it.

gballet · 2018-06-25T10:29:38Z

@karalabe thanks for the clarification

karalabe · 2018-06-25T13:41:00Z

core/vm/intpool.go

+			ip.inUse = true
+			return ip
+		}
+	}


I don't get why you're doing this boolean flag thing. Just keep the unused pools in here. When someone requests it, give it to them and remove it from the slice. When they return it, add it back to the slice (as long as it doesn't overflow).

holiman · 2018-06-25T17:13:21Z

Lgtm!

holiman · 2018-06-25T17:15:16Z

No, one comment; I think the stack still uses an intpool under the hood. That one (and any other callers of newIntPool) should use the ipp instead.

holiman · 2018-06-25T17:19:06Z

Also, should new pools still default to allocating a certain length of items? Iirc it's 1024, which seems excessive.

holiman · 2018-06-25T17:29:24Z

Hm, since the stack uses an intpool, might make sense to have more than five in the ipp. Otherwise, any callchain more than three or four (?) will cause ipp depletion. I still think a stack should have maybe max 100 items to start with

karalabe

Also, should new pools still default to allocating a certain length of items? Iirc it's 1024, which seems excessive.

I don't think it makes much sense to preallocate anything. If we free more than we use, it will pile up anyway eventually, and if we use more than we free, that it doesn't matter whether we preallocate or post-allocate. TL;DR I wouldn't preallocate any.

Hm, since the stack uses an intpool, might make sense to have more than five in the ipp. Otherwise, any callchain more than three or four (?) will cause ipp depletion.

We can have more than 5, maybe 25 to cover concurrent CALLS? Though take note, nested calls still use the same int pools.

I still think a stack should have maybe max 100 items to start with.

Why should a stack have starting items?

karalabe · 2018-06-25T18:20:53Z

core/vm/intpool.go

+	ipp.mutex.Lock()
+	defer ipp.mutex.Unlock()
+
+	if len(ipp.pools) < poolDefaultCap {


you could use if len(ipp.pools) < cap(ipp.pools) here and that would make the code more robust (i.e. if someone changes the constructor, this will keep in sync with it).

karalabe · 2018-06-25T18:21:44Z

core/vm/intpool.go

+}
+
+// release a pool that has been allocated with Get
+func (ipp *intPoolPool) release(ip *intPool) {


I think it would be better to name it put, to keep it consistent with sync.pool. Also it doesn't really release it, rather stick it back in.

karalabe · 2018-06-25T18:23:34Z

core/vm/intpool.go

+	}
+}
+
+var poolOfIntPools intPoolPool


You can be much more concise with:

var poolOfIntPools = &intPoolPool{ pools: make([]*intPool, 0, poolDefaultCap), }

karalabe · 2018-06-25T18:25:01Z

core/vm/intpool.go

+		ipp.pools = ipp.pools[:len(ipp.pools)-1]
+		return ip
+	}
+


Nitpick, but I generally don't leave empty lines after a } line. The goal of the empty line is to separate concepts, but } alone already acts ad good enough visual separator.

karalabe · 2018-06-25T18:29:48Z

core/vm/intpool.go

+
+const poolDefaultCap = 5
+
+// IntPoolPool manages a pool of intPools


lowercase pls, period at the end

karalabe · 2018-06-25T18:29:55Z

core/vm/intpool.go

+
+var poolOfIntPools intPoolPool
+
+// get is looking for an available pool to return


karalabe · 2018-06-25T18:29:59Z

core/vm/intpool.go

+	return newIntPool()
+}
+
+// release a pool that has been allocated with Get


holiman · 2018-06-25T19:02:57Z

Re nested calls, yes, same intpool, but new stacks - which are/use intpool internally. So yes but no.

karalabe · 2018-06-25T19:30:07Z

Oh, another optimization. When a run finishes, anything left on the stack can be moved back into the pool instead of GCd. Though to avoid many useless ops, we should also make put return a bool signifying whether there's any room left or not to allow fast breakouts.

holiman · 2018-06-25T19:47:26Z

I was wrong btw. An intpool uses a stack, not the other way around. A stack inits to 1024 in size

gballet · 2018-06-26T08:46:25Z

@karalabe I have added a new commit to declare an intPool and then getting its pool component as the stack.

@holiman from all your messages, I understood that you have no more issue about the cyclic dependency, is that correct?

karalabe · 2018-06-26T08:56:04Z

core/vm/interpreter.go

+			poolOfIntPools.put(in.intPool)
+			in.intPool = nil
+		}()
+	}


Please move this code up to the top. It should be an initialization code, currently it mixes in with the actual execution of the interpreter already.

couldn't do that since it now depends on the declaration of stack. See my upcoming change.

As we agreed, pls move this up.

karalabe · 2018-06-26T08:58:16Z

core/vm/interpreter.go

+	// Reclaim the stack as an int pool when the execution stops
+	defer func() {
+		poolOfIntPools.put(stackIP)
+	}()


You most definitely don't want to push the entire stack into the pool. Most of the stacks will be empty, or containing just a few items. By pushing it into the intPoolPool, you are taking precious resource space from genuine int pools which have many big.Int's cached. Instead of doing this, just pop off the stack items and push them into in.IntPool.

I see your point (at least I think I do): the pool will be small and more ints would have to be allocated when the next pool would have been sufficient.

The thing is, pushing on top of the other stack will also cause one allocation or more, depending on the capacity. And that pool could be re-used for another stack.

Which brings me to the following question: what about a pool of "shallow" stacks and one of "deep" stacks ? This way, we get some information about the pool's usage. Let me know if you think it's overkill.

karalabe · 2018-06-26T08:59:55Z

core/vm/interpreter.go

+		op      OpCode         // current opcode
+		mem     = NewMemory()  // bound memory
+		stackIP = newIntPool() // intPool holding the stack
+		stack   = stackIP.pool // local stack


I don't see the optimization here. A stack always starts out as empty, why would we want to use an intPool for it, the purpose of which is to not-be-empty.

the intpool is just a pointer to a stack; there's no optimization, just something that needs to be created anyway if the stackis pushed back onto the stack as an intPool

please read my other comments. the stack should not be pushed into the pool

ok, gotcha, in any case it should be get() and not newIntPool

no, it shouldn't be either. it should be the original code. get will get you a non-empty stack, you want an empty one... as in the original code.

yup, got it

karalabe · 2018-06-26T15:16:55Z

core/vm/interpreter.go

@@ -112,6 +111,10 @@ func (in *Interpreter) Run(contract *Contract, input []byte) (ret []byte, err er
 	// as every returning call will return new data anyway.
 	in.returnData = nil

+	if in.intPool == nil {
+		in.intPool = poolOfIntPools.get()
+	}


if in.intPool == nil { in.intPool = poolOfIntPools.get() defer func() { poolOfIntPools.put(in.intPool) in.intPool = nil }() }

karalabe · 2018-06-26T15:17:33Z

core/vm/interpreter.go

+		// Return the int pool to the pool
+		poolOfIntPools.put(in.intPool)
+		in.intPool = nil
+	}()


There's no point in putting in.intPool.put(stack.data...) into the defer. There's no point to put a defer here.

karalabe · 2018-06-27T08:15:07Z

core/vm/intpool.go

+type intPoolPool struct {
+	pools []*intPool
+
+	// Mutex


I don't think you need this comment here, just remove it + the empty line. It's fairly obvious.

karalabe · 2018-06-27T08:15:41Z

core/vm/intpool.go

+	pools []*intPool
+
+	// Mutex
+	mutex sync.Mutex


Nitpick, but throughout the code I usually use lock and Felix likes to use mu. Either is fine, but lets stick to one of those and not start a third naming for it :)

karalabe · 2018-06-27T08:15:51Z

core/vm/intpool.go

@@ -65,3 +68,40 @@ func (p *intPool) put(is ...*big.Int) {
 		p.pool.push(i)
 	}
 }
+
+const poolDefaultCap = 25


Pls add a doc.

karalabe · 2018-06-27T08:16:02Z

core/vm/intpool_test.go

+	poolOfIntPools.get()
+
+	if len(poolOfIntPools.pools) != 0 {
+


Pls delete empty line

karalabe · 2018-06-27T08:16:57Z

core/vm/intpool_test.go

+	poolOfIntPools.pools = make([]*intPool, 0, poolDefaultCap)
+
+	nip := poolOfIntPools.get()
+


I think you can delete this empty line here, code will be more compact and it's imho clean that your doing an op and ten checking that it's successful.

karalabe · 2018-06-27T08:16:59Z

core/vm/intpool_test.go

+	}
+
+	poolOfIntPools.put(nip)
+


I think you can delete this empty line here, code will be more compact and it's imho clean that your doing an op and ten checking that it's successful.

karalabe · 2018-06-27T10:18:49Z

core/vm/intpool_test.go

+	if len(poolOfIntPools.pools) != 0 {
+		t.Fatalf("Invalid number of pools. Got %d, expected %d", len(poolOfIntPools.pools), 0)
+	}
+	fmt.Println(len(poolOfIntPools.pools))


You forgot a println in here

karalabe · 2018-06-27T11:54:58Z

core/vm/intpool.go

+// intPoolPool manages a pool of intPools.
+type intPoolPool struct {
+	pools []*intPool
+


No need for an empty line here.

gballet · 2018-06-27T13:25:08Z

@karalabe rebased and squashed.

karalabe · 2018-06-28T10:01:25Z

I'd like to merge this in. Could you @gballet please move that code segment up as we agreed?

karalabe · 2018-07-02T09:37:33Z

core/vm/interpreter.go

@@ -133,6 +140,9 @@ func (in *Interpreter) Run(contract *Contract, input []byte) (ret []byte, err er
 	)
 	contract.Input = input

+	// Reclaim the stack as an int pool when the execution stops
+	defer in.intPool.put(stack.data...)


Ah, this is not good. The issue is that the parameters are evaluated here already (i.e. stack.data... evaluates into an empty list). https://play.golang.org/p/A5WL8nCKrIs

We need to defer the parameter evaluation too.

defer func() { in.intPool.put(stack.data...) }()

https://play.golang.org/p/4ayoTNxgwsY

karalabe

LGTM, although this PR doesn't seem to have much effect on the general allocation count according to the benchmarks. Apparently the big allocs don't come from this. Nonetheless it's a nice micro-optimization.

* core/vm: A pool for int pools * core/vm: fix rebase issue * core/vm: push leftover stack items after execution, not before

@riceke

* build: add -e and -X flags to get more information on ethereum#16433 (ethereum#16443) * core: remove stray account creations in state transition (ethereum#16470) The 'from' and 'to' methods on StateTransitions are reader methods and shouldn't have inadvertent side effects on state. It is safe to remove the check in 'from' because account existence is implicitly checked by the nonce and balance checks. If the account has non-zero balance or nonce, it must exist. Even if the sender account has nonce zero at the start of the state transition or no balance, the nonce is incremented before execution and the account will be created at that time. It is safe to remove the check in 'to' because the EVM creates the account if necessary. Fixes ethereum#15119 * travis, appveyor: bump to Go 1.10.1 * travis.yml: add TEST_PACKAGES to speed up swarm testing (ethereum#16456) This commit is meant to allow ecosystem projects such as ethersphere to minimize CI build times by specifying an environment variable with the packages to run tests on. If the environment variable isn't defined the build script will test all packages so this shouldn't affect the main go-ethereum repository. * les: add ps.lock.Unlock() before return (ethereum#16360) * core/state: fix bug in copy of copy State * core/state: fix ripemd-cornercase in Copy * core: txpool stable underprice drop order, perf fixes * miner: remove contention on currentMu for pending data retrievals (ethereum#16497) * ethdb: add leveldb write delay statistic (ethereum#16499) * eth/downloader: wait for all fetcher goroutines to exit before terminating (ethereum#16509) * cmd/clef, signer: initial poc of the standalone signer (ethereum#16154) * signer: introduce external signer command * cmd/signer, rpc: Implement new signer. Add info about remote user to Context * signer: refactored request/response, made use of urfave.cli * cmd/signer: Use common flags * cmd/signer: methods to validate calldata against abi * cmd/signer: work on abi parser * signer: add mutex around UI * cmd/signer: add json 4byte directory, remove passwords from api * cmd/signer: minor changes * cmd/signer: Use ErrRequestDenied, enable lightkdf * cmd/signer: implement tests * cmd/signer: made possible for UI to modify tx parameters * cmd/signer: refactors, removed channels in ui comms, added UI-api via stdin/out * cmd/signer: Made lowercase json-definitions, added UI-signer test functionality * cmd/signer: update documentation * cmd/signer: fix bugs, improve abi detection, abi argument display * cmd/signer: minor change in json format * cmd/signer: rework json communication * cmd/signer: implement mixcase addresses in API, fix json id bug * cmd/signer: rename fromaccount, update pythonpoc with new json encoding format * cmd/signer: make use of new abi interface * signer: documentation * signer/main: remove redundant option * signer: implement audit logging * signer: create package 'signer', minor changes * common: add 0x-prefix to mixcaseaddress in json marshalling + validation * signer, rules, storage: implement rules + ephemeral storage for signer rules * signer: implement OnApprovedTx, change signing response (API BREAKAGE) * signer: refactoring + documentation * signer/rules: implement dispatching to next handler * signer: docs * signer/rules: hide json-conversion from users, ensure context is cleaned * signer: docs * signer: implement validation rules, change signature of call_info * signer: fix log flaw with string pointer * signer: implement custom 4byte databsae that saves submitted signatures * signer/storage: implement aes-gcm-backed credential storage * accounts: implement json unmarshalling of url * signer: fix listresponse, fix gas->uint64 * node: make http/ipc start methods public * signer: add ipc capability+review concerns * accounts: correct docstring * signer: address review concerns * rpc: go fmt -s * signer: review concerns+ baptize Clef * signer,node: move Start-functions to separate file * signer: formatting * light: new CHTs (ethereum#16515) * params: release Geth v1.8.4 * VERSION, params: begin v1.8.5 release cycle * build: enable goimports and varcheck linters (ethereum#16446) * core/asm: remove unused condition (ethereum#16487) * cmd/utils: fix help template issue for subcommands (ethereum#16351) * rpc: clean up IPC handler (ethereum#16524) This avoids logging accept errors on shutdown and removes a bit of duplication. It also fixes some goimports lint warnings. * core/asm: accept uppercase instructions (ethereum#16531) * all: fix various typos (ethereum#16533) * fix typo * fix typo * fix typo * rpc: handle HTTP response error codes (ethereum#16500) * whisper/whisperv6: post returns the hash of sent message (ethereum#16495) * ethclient: add DialContext and Close (ethereum#16318) DialContext allows users to pass a Context object for cancellation. Close closes the underlying RPC connection. * vendor: update elastic/gosigar so that it compiles on OpenBSD (ethereum#16542) * eth/downloader: fix for Issue ethereum#16539 (ethereum#16546) * params: release Geth v1.8.5 - Dirty Derivative² * VERSION, params: begin Geth 1.8.6 release cycle * cmd/geth: update the copyright year in the geth command usage (ethereum#16537) * Revert "Dockerfile.alltools: fix invalid command" * Revert "cmd/puppeth: fix node deploys for updated dockerfile user" * Dockerfile: revert the user change PR that broke all APIs * Dockerfile: drop legacy discovery v5 port mappings * params: release v1.8.6 to fix docker images * VERSION, params: begin release cycle 1.8.7 * cmd/geth, mobile: add memsize to pprof server (ethereum#16532) * cmd/geth, mobile: add memsize to pprof server This is a temporary change, to be reverted before the next release. * cmd/geth: fix variable name * core/types: avoid duplicating transactions on changing signer (ethereum#16435) * core/state: cache missing storage entries (ethereum#16584) * cmd/utils: point users to --syncmode under DEPRECATED (ethereum#16572) Indicate that --light and --fast options are replaced by --syncmode * trie: remove unused `buf` parameter (ethereum#16583) * core, eth: fix tracer dirty finalization * travis.yml: remove obsolete brew-cask install * whisper: Golint fixes in whisper packages (ethereum#16637) * vendor: fix leveldb crash when bigger than 1 TiB * core: ensure local transactions aren't discarded as underpriced This fixes an issue where local transactions are discarded as underpriced when the pool and queue are full. * evm/main: use blocknumber from genesis * accounts: golint updates for this or self warning (ethereum#16627) * tests: golint fixes for tests directory (ethereum#16640) * trie: golint iterator fixes (ethereum#16639) * internal: golint updates for this or self warning (ethereum#16634) * core: golint updates for this or self warning (ethereum#16633) * build: Add ldflags -s -w when building aar Smaller size on mobile is always good. Might also solve our maven central upload problem * cmd/clef: documentation about setup (ethereum#16568) clef: documentation about setup * params: release geth 1.8.7 * VERSION, params: begin v1.8.8 release cycle * log: changed if-else blocks to conform with golint (ethereum#16661) * p2p: changed if-else blocks to conform with golint (ethereum#16660) * les: changed if-else blocks to conform with golint (ethereum#16658) * accounts: changed if-else blocks to conform with golint (ethereum#16654) * rpc: golint error with context as last parameter (ethereum#16657) * rpc/*: golint error with context as last parameter * Update json.go * metrics: golint updates for this or self warning (ethereum#16635) * metrics/*: golint updates for this or self warning * metrics/*: golint updates for this or self warning, updated pr from feedback * consensus/ethash: fixed typo (ethereum#16665) * event: golint updates for this or self warning (ethereum#16631) * event/*: golint updates for this or self warning * event/*: golint updates for this or self warning, pr updated per feedback * eth: golint updates for this or self warning (ethereum#16632) * eth/*:golint updates for this or self warning * eth/*: golint updates for this or self warning, pr updated per feedback * signer: fix golint errors (ethereum#16653) * signer/*: golint fixes Specifically naming and comment formatting for documentation * signer/*: fixed naming error crashing build * signer/*: corrected error * signer/core: fix tiny error whitespace * signer/rules: fix test refactor * whisper/mailserver: pass init error to the caller (ethereum#16671) * whisper/mailserver: pass init error to the caller * whisper/mailserver: add returns to fmt.Errorf * whisper/mailserver: check err in mailserver init test * common: changed if-else blocks to conform with golint (ethereum#16656) * mobile: add GetStatus Method for Receipt (ethereum#16598) * core/rawdb: separate raw database access to own package (ethereum#16666) * rlp: fix some golint warnings (ethereum#16659) * p2p: fix some golint warnings (ethereum#16577) * eth/filters: derive FilterCriteria from ethereum.FilterQuery (ethereum#16629) * p2p/simulations/adapters: fix websocket log line parsing in exec adapter (ethereum#16667) * build: specify the key to use when invoking gpg:sign-and-deploy-file (ethereum#16696) * crypto: fix golint warnings (ethereum#16710) * p2p: don't discard reason set by Disconnect (ethereum#16559) Peer.run was discarding the reason for disconnection sent to the disc channel by Disconnect. * cmd: various golint fixes (ethereum#16700) * cmd: various golint fixes * cmd: update to pr change request * cmd: update to pr change request * eth: golint fixes to variable names (ethereum#16711) * eth/filter: check nil pointer when unsubscribe (ethereum#16682) * eth/filter: check nil pointer when unsubscribe * eth/filters, accounts, rpc: abort system if subscribe failed * eth/filter: add crit log before exit * eth/filter, event: minor fixes * whisper/shhclient: update call to shh_generateSymKeyFromPassword to pass a string (ethereum#16668) * all: get rid of error when creating memory database (ethereum#16716) * all: get rid of error when create mdb * core: clean up variables definition * all: inline mdb definition * event: document select case slice use and add edge case test (ethereum#16680) Feed keeps active subscription channels in a slice called 'f.sendCases'. The Send method tracks the active cases in a local variable 'cases' whose value is f.sendCases initially. 'cases' shrinks to a shorter prefix of f.sendCases every time a send succeeds, moving the successful case out of range of the active case list. This can be confusing because the two slices share a backing array. Add more comments to document what is going on. Also add a test for removing a case that is in 'f.sentCases' but not 'cases'. * travis: use Android NDK 16b (ethereum#16562) * bmt: golint updates for this or self warning (ethereum#16628) * bmt/*: golint updates for this or self warning * Update bmt.go * light: new CHT for mainnet and ropsten (ethereum#16736) * params: release go-ethereum v1.8.8 * VERSION, params: start 1.8.9 release cycle * accounts/abi: allow abi: tags when unpacking structs Go code users can now tag event struct members with `abi:` to specify in what fields the event will be de-serialized. See PR ethereum#16648 for details. * travis: try to upgrade android builder to trusty * p2p/enr: updates for discovery v4 compatibility (ethereum#16679) This applies spec changes from ethereum/EIPs#1049 and adds support for pluggable identity schemes. Some care has been taken to make the "v4" scheme standalone. It uses public APIs only and could be moved out of package enr at any time. A couple of minor changes were needed to make identity schemes work: - The sequence number is now updated in Set instead of when signing. - Record is now copy-safe, i.e. calling Set on a shallow copy doesn't modify the record it was copied from. * all: collate new transaction events together * core, eth: minor txpool event cleanups * travis, appveyor: bump Go release to 1.10.2 * core, consensus: fix some typos in comment code and output log * eth: propagate blocks and transactions async * trie: fixes to comply with golint (ethereum#16771) * log: fixes for golint warnings (ethereum#16775) * node: all golint warnings fixed (ethereum#16773) * node: all golint warnings fixed * node: rm per peter * node: rm per peter * vendor, ethdb: print warning log if leveldb is performing compaction (ethereum#16766) * vendor: update leveldb package * ethdb: print warning log if db is performing compaction * ethdb: update annotation and log * core/types: convert status type from uint to uint64 (ethereum#16784) * trie: support proof generation from the iterator * core/vm: fix typo in instructions.go (ethereum#16788) * core: use a wrapped map to remove contention in `TxPool.Get`. (ethereum#16670) * core: use a wrapped `map` and `sync.RWMutex` for `TxPool.all` to remove contention in `TxPool.Get`. * core: Remove redundant `txLookup.Find` and improve comments on txLookup methods. * trie: cleaner logic, one less func call * eth, node, trie: fix minor typos (ethereum#16802) * params: release go-ethereum v1.8.9 * VERSION, params: begin 1.8.10 release cycle * ethereum: fix a typo in FilterQuery{} (ethereum#16827) Fix a spelling mistake in comment * eth/fetcher: reuse variables for hash and number (ethereum#16819) * whisper/shhclient: update call to shh_post to expect string instead of bool (ethereum#16757) Fixes ethereum#16756 * common: improve documentation comments (ethereum#16701) This commit adds many comments and removes unused code. It also removes the EmptyHash function, which had some uses but was silly. * core/vm: fix typo in comment * p2p/discv5: add egress/ingress traffic metrics to discv5 udp transport (ethereum#16369) * core: improve test for TransactionPriceNonceSort (ethereum#16413) * trie: rename TrieSync to Sync and improve hexToKeybytes (ethereum#16804) This removes a golint warning: type name will be used as trie.TrieSync by other packages, and that stutters; consider calling this Sync. In hexToKeybytes len(hex) is even and (even+1)/2 == even/2, remove the +1. * core: fix transaction event asynchronicity * params: release Geth 1.8.10 hotfix * VERSION, params: begin 1.8.11 release cycle * ethstats: fix last golint warning (ethereum#16837) * console: squash golint warnings (ethereum#16836) * rpc: use HTTP request context as top-level context (ethereum#16861) * consensus/ethash: reduce keccak hash allocations (ethereum#16857) Use Read instead of Sum to avoid internal allocations and copying the state. name old time/op new time/op delta CacheGeneration-8 764ms ± 1% 579ms ± 1% -24.22% (p=0.000 n=20+17) SmallDatasetGeneration-8 75.2ms ±12% 60.6ms ±10% -19.37% (p=0.000 n=20+20) HashimotoLight-8 1.58ms ±11% 1.55ms ± 8% ~ (p=0.322 n=20+19) HashimotoFullSmall-8 4.90µs ± 1% 4.88µs ± 1% -0.31% (p=0.013 n=19+18) * core, eth, trie: streaming GC for the trie cache (ethereum#16810) * core, eth, trie: streaming GC for the trie cache * trie: track memcache statistics * rpc: set timeouts for http server, see ethereum#16859 * metrics: expvar support for ResettingTimer (ethereum#16878) * metrics: expvar support for ResettingTimer * metrics: use integers for percentiles; remove Overall * metrics: fix edge-case panic for index-out-of-range * cmd/geth: cap cache allowance * core: fix typo in comment code * les: add Skip overflow check to GetBlockHeadersMsg handler (ethereum#16891) * eth/tracers: fix minor off-by-one error (ethereum#16879) * tracing: fix minor off-by-one error * tracers: go generate * core: concurrent background transaction sender ecrecover * miner: not call commitNewWork if it's a side block (ethereum#16751) * cmd/abigen: support for reading solc output from stdin (ethereum#16683) Allow the --abi flag to be given - to indicate that it should read the ABI information from standard input. It expects to read the solc output with the --combined-json flag providing bin, abi, userdoc, devdoc, and metadata, and works very similarly to the internal invocation of solc, except it allows external invocation of solc. This facilitates integration with more complex solc invocations, such as invocations that require path remapping or --allow-paths tweaks. Simple usage example: solc --combined-json bin,abi,userdoc,devdoc,metadata *.sol | abigen --abi - * params: fix golint warnings (ethereum#16853) params: fix golint warnings * vendor: added vendor packages necessary for the swarm-network-rewrite merge (ethereum#16792) * vendor: added vendor packages necessary for the swarm-network-rewrite merge into ethereum master * vendor: removed multihash deps * trie: reduce hasher allocations (ethereum#16896) * trie: reduce hasher allocations name old time/op new time/op delta Hash-8 4.05µs ±12% 3.56µs ± 9% -12.13% (p=0.000 n=20+19) name old alloc/op new alloc/op delta Hash-8 1.30kB ± 0% 0.66kB ± 0% -49.15% (p=0.000 n=20+20) name old allocs/op new allocs/op delta Hash-8 11.0 ± 0% 8.0 ± 0% -27.27% (p=0.000 n=20+20) * trie: bump initial buffer cap in hasher * whisper: re-insert ethereum#16757 that has been lost during a merge (ethereum#16889) * cmd/puppeth: fixed a typo in a wizard input query (ethereum#16910) * core: relax type requirement for bc in ApplyTransaction (ethereum#16901) * trie: avoid unnecessary slicing on shortnode decoding (ethereum#16917) optimization code * cmd/ethkey: add command to change key passphrase (ethereum#16516) This change introduces ethkey changepassphrase <keyfile> to change the passphrase of a key file. * metrics: return an empty snapshot for NilResettingTimer (ethereum#16930) * light: new CHTs for mainnet and ropsten (ethereum#16926) * ethclient: fix RPC parse error of Parity response (ethereum#16924) The error produced when using a Parity RPC was the following: ERROR: transaction did not get mined: failed to get tx for txid 0xbdeb094b3278019383c8da148ff1cb5b5dbd61bf8731bc2310ac1b8ed0235226: json: cannot unmarshal non-string into Go struct field txExtraInfo.blockHash of type common.Hash * core: improve getBadBlocks to return full block rlp (ethereum#16902) * core: improve getBadBlocks to return full block rlp * core, eth, ethapi: changes to getBadBlocks formatting * ethapi: address review concerns * rpc: fix a comment typo (ethereum#16929) * rpc: support returning nil pointer big.Ints (null) * trie: don't report the root flushlist as an alloc * metrics: removed repetitive calculations (ethereum#16944) * core/rawdb: wrap db key creations (ethereum#16914) * core/rawdb: use wrappered helper to assemble key * core/rawdb: wrappered helper to assemble key * core/rawdb: rewrite the wrapper, pass common.Hash * ethdb: gracefullly handle quit channel (ethereum#16794) * ethdb: gratefullly handle quit channel * ethdb: minor polish * internal/ethapi: reduce pendingTransactions to O(txs+accs) from O(txs*accs) * les: pass server pool to protocol manager (ethereum#16947) * metrics: fix gofmt linter warnings * crypto: replace ToECDSAPub with error-checking func UnmarshalPubkey (ethereum#16932) ToECDSAPub was unsafe because it returned a non-nil key with nil X, Y in case of invalid input. This change replaces ToECDSAPub with UnmarshalPubkey across the codebase. * core, eth, les: more efficient hash-based header chain retrieval (ethereum#16946) * les: fix retriever logic (ethereum#16776) This PR fixes a retriever logic bug. When a peer had a soft timeout and then a response arrived, it always assumed it was the same peer even though it could have been a later requested one that did not time out at all yet. In this case the logic went to an illegal state and deadlocked, causing a goroutine leak. Fixes ethereum#16243 and replaces ethereum#16359. Thanks to @riceke for finding the bug in the logic. * params: release go-ethereum v1.8.11 * VERSION, params: begin v1.8.12 release cycle * core: change comment to match code more closely (ethereum#16963) * internal/web3ext: fix method name for enabling mutex profiling (ethereum#16964) * eth/fetcher: fix annotation (ethereum#16969) * core/asm: correct comments typo (ethereum#16975) core/asm/lexer: correct comments typo * console: correct some comments typo (ethereum#16971) console/console: correct some comments typo * ethereum#15685 made peer_test.go more portable by using random free port instead of hardcoded port 30303 (ethereum#15687) Improves test portability by resolving 127.0.0.1:0 to get a random free port instead of the hard coded one. Now the test works if you have a running node on the same interface already. Fixes ethereum#15685 * all: library changes for swarm-network-rewrite (ethereum#16898) This commit adds all changes needed for the merge of swarm-network-rewrite. The changes: - build: increase linter timeout - contracts/ens: export ensNode - log: add Output method and enable fractional seconds in format - metrics: relax test timeout - p2p: reduced some log levels, updates to simulation packages - rpc: increased maxClientSubscriptionBuffer to 20000 * core/vm: optimize MSTORE and SLOAD (ethereum#16939) * vm/test: add tests+benchmarks for mstore * core/vm: less alloc and copying for mstore * core/vm: less allocs in sload * vm: check for errors more correctly * eth/filters: make filterLogs func more readable (ethereum#16920) * cmd/utils: fix NetworkId default when -dev is set (ethereum#16833) Prior to this change, when geth was started with `geth -dev -rpc`, it would report a network id of `1` in response to the `net_version` RPC request. But the actual network id it used to verify transactions was `1337`. This change causes geth instead respond with `1337` to the `net_version` RPC when geth is started with `geth -dev -rpc`. * travis, appveyor: update to Go 1.10.3 * common: all golint warnings removed (ethereum#16852) * common: all golint warnings removed * common: fixups * eth: conform better to the golint standards (ethereum#16783) * eth: made changes to conform better to the golint standards * eth: fix comment nit * core: reduce nesting in transaction pool code (ethereum#16980) * bmt: fix package documentation comment (ethereum#16909) * common/number: delete unused package (ethereum#16983) This package was meant to hold an improved 256 bit integer library, but the effort was abandoned in 2015. AFAIK nothing ever used this package. Time to say goodbye. * core/asm: correct comments typo (ethereum#16974) * core/asm/compiler: correct comments typo core/asm/compiler: correct comments typo * Correct comments typo * internal/debug: use pprof goroutine writer for debug_stacks (ethereum#16892) * debug: Use pprof goroutine writer in debug.Stacks() to ensure all goroutines are captured. * Up to 64MB limit, previous code only captured first 1MB of goroutines. * internal/debug: simplify stacks handler * fix typo * fix pointer receiver * accounts/keystore: assign schema as const instead of var (ethereum#16985) * cmd: remove faucet/puppeth dead code (ethereum#16991) * cmd/faucet: authGitHub is not used anymore * cmd/puppeth: remove not used code * mobile: correct comment typo in geth.go (ethereum#17021) * accounts/usbwallet: correct comment typo (ethereum#17008) * core: remove dead code, limit test code scope (ethereum#17006) * core: move test util var/func to test file * core: remove useless func * accounts/usbwallet: correct comment typo (ethereum#16998) * signer: remove useless errorWrapper (ethereum#17003) * travis: use NDK 17b for Android archives (ethereum#17029) * tracers: fix err in 4byte, add some opcode analysis tools * accounts: remove deadcode isSigned (ethereum#16990) * mobile: correct comment typo in ethereum.go (ethereum#17040) * cmd/geth: remove the tail "," from genesis config (ethereum#17028) remove the tail "," from genesis config, which will cause genesis config parse error . * trie: cache collapsed tries node, not rlp blobs (ethereum#16876) The current trie memory database/cache that we do pruning on stores trie nodes as binary rlp encoded blobs, and also stores the node relationships/references for GC purposes. However, most of the trie nodes (everything apart from a value node) is in essence just a collection of references. This PR switches out the RLP encoded trie blobs with the collapsed-but-not-serialized trie nodes. This permits most of the references to be recovered from within the node data structure, avoiding the need to track them a second time (expensive memory wise). * swarm: network rewrite merge * les: handle conn/disc/reg logic in the eventloop (ethereum#16981) * les: handle conn/disc/reg logic in the eventloop * les: try to dial before start eventloop * les: handle disconnect logic more safely * les: grammar fix * log: Change time format - Keep the tailing zeros. - Limit precision to milliseconds. * swarm/fuse: Disable fuse tests, they are flaky (ethereum#17072) * swarm/pss: Hide big network tests under longrunning flag (ethereum#17074) * whisper: Reduce message loop log from Warn to Info (ethereum#17055) * core/vm: clear linter warnings (ethereum#17057) * core/vm: clear linter warnings * core/vm: review input * core/vm.go: revert lint in noop as per request * build: make build/goimports.sh more potable * node: remove formatting from ResettingTimer metrics if requested in raw * ethstats: comment minor correction (ethereum#17102) spell correction from `repors` to `reports` * ethdb, core: implement delete for db batch (ethereum#17101) * vendor: update docker/docker/pkg/reexec so that it compiles on OpenBSD (ethereum#17084) * trie: fix a temporary memory leak in the memcache * cmd/geth: export metrics to InfluxDB (ethereum#16979) * cmd/geth: add flags for metrics export * cmd/geth: update usage fields for metrics flags * metrics/influxdb: update reporter logger to adhere to geth logging convention * node: documentation typo fix (ethereum#17113) * core/vm: reuse bigint pools across transactions (ethereum#17070) * core/vm: A pool for int pools * core/vm: fix rebase issue * core/vm: push leftover stack items after execution, not before * cmd/p2psim: add exit error output and exit code (ethereum#17116) * p2p/discover: move bond logic from table to transport (ethereum#17048) * p2p/discover: move bond logic from table to transport This commit moves node endpoint verification (bonding) from the table to the UDP transport implementation. Previously, adding a node to the table entailed pinging the node if needed. With this change, the ping-back logic is embedded in the packet handler at a lower level. It is easy to verify that the basic protocol is unchanged: we still require a valid pong reply from the node before findnode is accepted. The node database tracked the time of last ping sent to the node and time of last valid pong received from the node. Node endpoints are considered verified when a valid pong is received and the time of last pong was called 'bond time'. The time of last ping sent was unused. In this commit, the last ping database entry is repurposed to mean last ping _received_. This entry is now used to track whether the node needs to be pinged back. The other big change is how nodes are added to the table. We used to add nodes in Table.bond, which ran when a remote node pinged us or when we encountered the node in a neighbors reply. The transport now adds to the table directly after the endpoint is verified through ping. To ensure that the Table can't be filled just by pinging the node repeatedly, we retain the isInitDone check. During init, only nodes from neighbors replies are added. * p2p/discover: reduce findnode failure counter on success * p2p/discover: remove unused parameter of loadSeedNodes * p2p/discover: improve ping-back check and comments * p2p/discover: add neighbors reply nodes always, not just during init * consensus/ethash: fixed documentation typo (ethereum#17121) "proot-of-work" to "proof-of-work" * light: new CHTs (ethereum#17124) * les: add announcement safety check to light fetcher (ethereum#17034) * params: v1.8.12 stable * 1.8.12

gballet requested a review from karalabe June 25, 2018 08:39

gballet requested a review from holiman as a code owner June 25, 2018 08:39

gballet commented Jun 25, 2018

View reviewed changes

karalabe reviewed Jun 25, 2018

View reviewed changes

gballet commented Jun 25, 2018

View reviewed changes

karalabe reviewed Jun 25, 2018

View reviewed changes

karalabe requested changes Jun 25, 2018

View reviewed changes

karalabe requested changes Jun 26, 2018

View reviewed changes

karalabe reviewed Jun 26, 2018

View reviewed changes

karalabe reviewed Jun 27, 2018

View reviewed changes

core/vm/intpool_test.go Outdated

poolOfIntPools.get()

if len(poolOfIntPools.pools) != 0 {

Copy link

Member

karalabe Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls delete empty line

karalabe reviewed Jun 27, 2018

View reviewed changes

gballet force-pushed the intpoolpool branch from df45778 to ae3eed5 Compare June 27, 2018 12:55

core/vm: A pool for int pools

e64b41b

gballet force-pushed the intpoolpool branch from ae3eed5 to e64b41b Compare June 27, 2018 13:23

core/vm: fix rebase issue

91016a7

karalabe added this to the 1.8.12 milestone Jul 2, 2018

karalabe reviewed Jul 2, 2018

View reviewed changes

core/vm: push leftover stack items after execution, not before

078ff10

karalabe approved these changes Jul 3, 2018

View reviewed changes

karalabe merged commit 4e5d1f1 into ethereum:master Jul 3, 2018


		const poolDefaultCap = 5

		// IntPoolPool manages a pool of intPools


		var poolOfIntPools intPoolPool

		// get is looking for an available pool to return

		poolOfIntPools.pools = make([]*intPool, 0, poolDefaultCap)

		nip := poolOfIntPools.get()

core/vm: first version of the intpool pool #17070

core/vm: first version of the intpool pool #17070

Conversation

gballet commented Jun 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gballet commented Jun 25, 2018

Choose a reason for hiding this comment

holiman commented Jun 25, 2018

holiman commented Jun 25, 2018

holiman commented Jun 25, 2018

holiman commented Jun 25, 2018 • edited Loading

karalabe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

holiman commented Jun 25, 2018

karalabe commented Jun 25, 2018

holiman commented Jun 25, 2018

gballet commented Jun 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gballet Jun 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karalabe Jun 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gballet commented Jun 27, 2018

karalabe commented Jun 28, 2018

Choose a reason for hiding this comment

karalabe left a comment

Choose a reason for hiding this comment

holiman commented Jun 25, 2018 •

edited

Loading

gballet Jun 26, 2018 •

edited

Loading

karalabe Jun 26, 2018 •

edited

Loading