build: clean go build cache when necessary #17079
Conversation
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
- clean go build cache when necessary Signed-off-by: Hyung-Kyu Choi <hqueue@users.noreply.github.com>
hqueue
changed the title
build/clean_go_build_cache.sh
Outdated
| if [[ $version =~ $regex ]]; then | ||
| echo ${BASH_REMATCH[1]} | ||
| fi | ||
| } |
There was a problem hiding this comment.
/bin/bash is not preferred. you can use the following snippet.golang_version=$(go version |cut -d' ' -f3 |sed 's/go//')
There was a problem hiding this comment.
Thanks for the suggestion. I will update the PR.
|
Thank you for your contribution! Your commits seem to not adhere to the repository coding standards
Please check the contribution guidelines for more details. This message was auto-generated by https://gitcop.com |
- use /bin/sh intead of /bin/bash Signed-off-by: Hyung-Kyu Choi <hqueue@users.noreply.github.com>
|
@hackmod PR updated. Please take another look :) |
|
I think your PR just won some legitimacy :) golang/go#24355 |
Signed-off-by: Hyung-Kyu Choi hqueue@users.noreply.github.com
This fixes #17078