core/state: remove lock #18065
Merged
core/state: remove lock #18065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lock in StateDB is useless. It's only held in Copy, but Copy is safe for concurrent use because all it does is read.
|
I agree it's useless as is. Question though: instead of removing it for |
|
No, because StateDB is not safe for concurrent use. The correct way to use StateDB is doing all modifications from a single goroutine at a time and copying the DB if it is to be passed to a different goroutine. We use this pattern for the pending state. |
holiman
approved these changes
Nov 8, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock in StateDB is useless. It's only held in Copy, but Copy is safe
for concurrent use because all it does is read.