Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: make tracers respect pre-EIP158/161 rules #18503

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 23, 2019

This PR is on top of #18502 .
The tracers, when computing the statedb in various places, told the statedb.Finalise method to delete empty objects, and did not check whether EIP 158/161 was activated.
This causes erroneous traces for historic transactions, as seen in #18331

EDIT: rebased now that #18502 is merged

@holiman
Copy link
Contributor Author

holiman commented Jan 24, 2019

pingng @mtbitcoin -- for Etherscan, you might need to re-execute those same old transactions with this PR (a few of them are reported in the linked tickets) because Etherscan shows the erroneous traces.

Also, it might make sense for Etherscan to use the functionality from #17914 to provide more complete traces with less resource-intensive processing.

@mtbitcoin
Copy link

@holiman can you provide a sample txhash with the "erroneous traces" ?

@holiman
Copy link
Contributor Author

holiman commented Jan 24, 2019

From the original bug report, here's one:
https://etherscan.io/tx/0xfb200dc759b00dc69c0578fbce9df31d08c97dc33bc82c84c3b92f3071a4f65b
Gas used (correct): 37888
Trace: https://etherscan.io/vmtrace?txhash=0xfb200dc759b00dc69c0578fbce9df31d08c97dc33bc82c84c3b92f3071a4f65b at step 270 it says the gascost is 25061, which is incorrect.

@holiman
Copy link
Contributor Author

holiman commented Jan 30, 2019

Fixes #18331 , #17590 and #16693

@holiman holiman merged commit 05d2143 into ethereum:master Feb 1, 2019
@holiman holiman added this to the 1.9.0 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants