Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update leveldb #19163

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

rjl493456442
Copy link
Member

This PR includes a leveldb fix for long time compaction.

The upstream PR is here. Open this PR for experiment right now.

@rjl493456442
Copy link
Member Author

rjl493456442 commented Feb 27, 2019

A few benchmarking updates:

The experiment branch with fix now is about 100k blocks ahead. And currently no Database compacting, degraded performance log printed at all. While the master branch suffers to write pause about 37min per hour.

Currently, the database size of the experiment branch is 518G, sstable file number is 272317.

block difference diagram: the block difference is gradually increasing.

image

Data write speed, the below one is master branch. It is obvious that write speed becomes very low at regular intervals. It means disk io is almost idle while compaction is still undergoing

image

Master branch execution time vs state write time: It is obvious that the duration of data writing takes up almost the entire time required for a block import at regular intervals.

image

Experiment branch execution time vs state write time: State write time is very stable while execution time is increasing gradually
image

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@karalabe
Copy link
Member

I'll merge this PR, more time on master to notice any issues. The benchmarks we can keep running to see how import times evolve over the next few days. Curious how much time a full archive sync will take.

@karalabe karalabe added this to the 1.9.0 milestone Feb 27, 2019
@karalabe karalabe merged commit 7ebd2fa into ethereum:master Feb 27, 2019
kiku-jw pushed a commit to kiku-jw/go-ethereum that referenced this pull request Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants