graphql: check the integrity of the cdn files #19742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkomisi
force-pushed
the
graphql-asset-integrity-check
branch
from
81e4466 to
3a4f61c
Compare
holiman
approved these changes
Jun 20, 2019
|
This PR seems a bit complicated now. If we're not embedding the network resources, then I think we should omit the whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #19727
The graphql explorer relies on external cdn files, and verifying their integrity guarantees that the fetched resources have been delivered without unexpected manipulation.
For the mechanism of the subresource integrity check see https://www.w3.org/TR/SRI/.
https://www.srihash.org/ is used to calculate the correct hashes.
Thanks @holiman for the pinpoints.