Eip 1344 (ChainID opcode) #19921
Merged
Eip 1344 (ChainID opcode) #19921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoreyLin
reviewed
Aug 7, 2019
CoreyLin
reviewed
Aug 7, 2019
| @@ -101,6 +101,8 @@ const ( | |||
| NUMBER | |||
| DIFFICULTY | |||
| GASLIMIT | |||
| CHAINID = 0x46 | |||
There was a problem hiding this comment.
Maybe "= 0x46" and "= 0x47" could be omitted because of iota effect.
There was a problem hiding this comment.
They could, but I dislike the iota effect -- imo it's wrong to use iota to define something that is defined externally, and it should only be used for things where there's no external dependency -- where only internal consistency matters
CoreyLin
reviewed
Aug 7, 2019
tests/state_test_util.go
Outdated
| config, ok := Forks[subtest.Fork] | ||
| if !ok { | ||
| config, eips, err := getVMConfig(subtest.Fork) | ||
| if err != nil { |
There was a problem hiding this comment.
Maybe it could be modified to:
if config, eips, err := getVMConfig(subtest.Fork); err != nil {
|
Pls rebase. |
|
rebased |
rjl493456442
reviewed
Aug 8, 2019
holiman
commented
Aug 8, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of 1344. This PR is built on top of #19743 , which contains some necessary framework.
Neither of these PRs actually enable it for Istanbul (that needs a follow-up PR). So in that sense, they should both be fairly safe to merge.
cc @fubuloubu (only the last commit is relevant)