Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/puppeth: make ssh prompt more user-friendly #20350

Merged
merged 1 commit into from
Nov 21, 2019
Merged

cmd/puppeth: make ssh prompt more user-friendly #20350

merged 1 commit into from
Nov 21, 2019

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Nov 21, 2019

Related to #16997 , this PR makes puppeth nicer when user tries to respond y instead of yes to a query

@holiman holiman requested a review from karalabe as a code owner November 21, 2019 10:05
karalabe
karalabe reviewed Nov 21, 2019
View reviewed changes
cmd/puppeth/ssh.go Outdated Show resolved Hide resolved
@holiman
Copy link
Contributor Author

holiman commented Nov 21, 2019

done

karalabe
karalabe reviewed Nov 21, 2019
View reviewed changes
cmd/puppeth/ssh.go Outdated Show resolved Hide resolved
karalabe
karalabe approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.8 milestone Nov 21, 2019
@karalabe karalabe merged commit f56f969 into ethereum:master Nov 21, 2019
@ricardolyn ricardolyn mentioned this pull request Jan 27, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.8
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @karalabe