Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/usbwallet: fix staticcheck warnings #20372

Merged
merged 2 commits into from
Nov 29, 2019
Merged

accounts/usbwallet: fix staticcheck warnings #20372

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afaa9e1
accounts/usbwallet: fix staticcheck warnings
gballet Nov 22, 2019
482db9c
review feedback
gballet Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions accounts/usbwallet/ledger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ func (w *ledgerDriver) SignTx(path accounts.DerivationPath, tx *types.Transactio
return common.Address{}, nil, accounts.ErrWalletClosed
}
// Ensure the wallet is capable of signing the given transaction
if chainID != nil && w.version[0] <= 1 && w.version[1] <= 0 && w.version[2] <= 2 {
return common.Address{}, nil, fmt.Errorf("Ledger v%d.%d.%d doesn't support signing this transaction, please update to v1.0.3 at least", w.version[0], w.version[1], w.version[2])
if chainID != nil && w.version[0] <= 1 && w.version[2] <= 2 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the version[1] check?

Copy link
Member Author

@gballet gballet Nov 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because staticcheck complains that a byte is always greater than or equal to 0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point :P

return common.Address{}, nil, fmt.Errorf("ledger v%d.%d.%d doesn't support signing this transaction, please update to v1.0.3 at least", w.version[0], w.version[1], w.version[2])
gballet marked this conversation as resolved.
Show resolved Hide resolved
}
// All infos gathered and metadata checks out, request signing
return w.ledgerSign(path, tx, chainID)
Expand Down