Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/geth: remove network id from version cmd #20385

Merged
merged 1 commit into from
Nov 25, 2019
Merged

cmd/geth: remove network id from version cmd #20385

merged 1 commit into from
Nov 25, 2019

Conversation

meowsbits
Copy link
Contributor

Resolves #20377

@meowsbits
cmd/geth: remove network id from version cmd
d9d2a4e 
It was reflective only of the Default setting,
and not chain aware.
@karalabe karalabe added this to the 1.9.8 milestone Nov 25, 2019
karalabe
karalabe approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit 9ef90db into ethereum:master Nov 25, 2019
@meowsbits meowsbits mentioned this pull request Dec 18, 2019
Closed
@ricardolyn ricardolyn mentioned this pull request Jan 27, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.8
Development

Successfully merging this pull request may close these issues.

geth 'version' command gives wrong NetworkID value when used with [--<chain>|--networkid] flags
2 participants
@meowsbits @karalabe