console, internal/jsre: use goja #20470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completion tests still seem to fail
It didn't complete 'St' to 'String' for some reason. Now it does, and the code is much simpler.
Also improve a few minor details in the bridge. We can now sleep for sub-second amounts, for example.
This speeds up geth startup by 5ms because the asset is only loaded when the console used instead of loading it unconditionally during package init time.
The old one worked, but evaluating JS code created from server-provided input is weird and can lead to RCE in case the console is used with a malicious server.
fjl
approved these changes
Jan 27, 2020
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
This replaces the JavaScript interpreter used by the console with goja, which is actively maintained and a lot faster than otto. Clef still uses otto and eth/tracers still uses duktape, so we are currently dependent on three different JS interpreters. We're looking to replace the remaining uses of otto soon though.
9 tasks
wgr523
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Nov 1, 2023
This replaces the JavaScript interpreter used by the console with goja, which is actively maintained and a lot faster than otto. Clef still uses otto and eth/tracers still uses duktape, so we are currently dependent on three different JS interpreters. We're looking to replace the remaining uses of otto soon though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #19761 was becoming too complex and also really hard to rebase, I have decided to break the switch into several sub-PR to make it easier to review.
This is the first PR, in which only the console is switched to goja. The signer still uses otto and the tracer still uses duktape.
Closes #14649