core: fix indexer unit test #20506
Merged
core: fix indexer unit test #20506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
fix-chain-indexers
branch
from
3725b32
to
c328a51
Compare
kjx98
pushed a commit
to kjx98/go-ethereum
that referenced
this pull request
Jan 23, 2020
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unit tests of chain indexers.
In #19748 we fix an issue in chain indexer when it tries to run reorg. The change is the given
headinnewHeadfunction is thecommon ancestorof new head header and previous head header. Soheadis still considered valid. The change merged is usingknown := (head + 1) / c.sectionSizeto calculate the section index which need to be reverted instead of usinghead/c.sectionSize.But we don't change the unit test, this PR just follow the original merged change.
Fixes #20497