Improved blockhash caching #20589
Merged
Improved blockhash caching #20589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Jan 29, 2020
gballet
reviewed
Jan 29, 2020
karalabe
reviewed
Feb 4, 2020
holiman
force-pushed
the
mininal_bhashfix
branch
from
3abe832
to
8ba3166
Compare
holiman
force-pushed
the
mininal_bhashfix
branch
from
8ba3166
to
8d05c59
Compare
karalabe
requested changes
Feb 4, 2020
core/vm/runtime/runtime_test.go
Outdated
| t.Fatalf("Expected no error, got %v", err) | ||
| } | ||
| if len(ret) != 96 { | ||
| t.Fatalf("Expected returndata to be 96 bytes, got %d", len(ret)) |
core/vm/runtime/runtime_test.go
Outdated
| BlockNumber: new(big.Int).Set(header.Number), | ||
| }) | ||
| if err != nil { | ||
| t.Fatalf("Expected no error, got %v", err) |
9 tasks
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* core/vm/runtime: add test for blockhash * core/evm: less iteration in blockhash * core/vm/runtime: nitpickfix Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've realized that #19319 might never make it in. It's quite big.
So, here's a very small PR which, although not as awesome as that one, is still a lot better than the way things work currently.