internal/ethapi: don't set sender-balance to maxuint, fixes #16999 #20783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
requested review from
karalabe,
rjl493456442 and
zsfelfoldi
as code owners
|
The fix seems reasonable, we just need to make sure it doesn't touch some strange code path. Btw, can't we get rid of that |
fjl
changed the title
|
Please fix the lint error. |
|
This change makes eth_call semantics a lot less surprising. I'm pretty something will break, but let's merge anyway. |
fjl
approved these changes
Mar 23, 2020
|
Thank you |
AusIV
added a commit
to NoteGio/go-ethereum
that referenced
this pull request
Aug 20, 2020
AusIV
added a commit
to NoteGio/go-ethereum
that referenced
this pull request
Nov 12, 2020
15 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
…16999 (ethereum#20783) Prior to this change, eth_call changed the balance of the sender account in the EVM environment to 2^256 wei to cover the gas cost of the call execution. We've had this behavior for a long time even though it's super confusing. This commit sets the default call gasprice to zero instead of updating the balance, which is better because it makes eth_call semantics less surprising. Removing the built-in balance assignment also makes balance overrides work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16999 , but it may cause problem in other areas. Not sure what do do here...