snapshotter/tests: verify snapdb post-state against trie #20812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Mar 30, 2020
core/state/snapshot/account.go
Outdated
| } | ||
|
|
||
| // SlimToFull converts data on the 'slim RLP' format into the full RLP-format | ||
| func SlimToFull(data []byte) []byte { |
There was a problem hiding this comment.
Please return an error if rlp.Decode fails. We'll need it when parsing data from the snap protocol.
There was a problem hiding this comment.
I think I'd move this and conversionAccount into conversion.go until it's clear where it goes. Don't want to litter the package. I'm unsure this is a method we want to keep long term, seems weird to do three ops in on (decode, convert, recode).
karalabe
reviewed
Mar 30, 2020
core/state/snapshot/conversion.go
Outdated
| "github.com/ethereum/go-ethereum/trie" | ||
| ) | ||
|
|
||
| type leaf struct { |
There was a problem hiding this comment.
This is not a leaf. Its a key/value entry in the trie.
karalabe
reviewed
Mar 30, 2020
core/state/snapshot/conversion.go
Outdated
|
|
||
| // StdGenerate is a very basic hexary trie builder which uses the same Trie | ||
| // as the rest of geth, with no enhancements or optimizations | ||
| func StdGenerate(in chan (leaf), out chan (common.Hash)) { |
There was a problem hiding this comment.
No, not in this PR. I'm changing it.
It was public because we later might want to expose it to the geth cli command, so we can do snaphash.
15 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a snapshot vs trie reconciliation after running blockchain tests, to ensure that the state-according-to-snapshot is consistent with the state-according-to-trie.