Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p/server: add UDP port mapping goroutine to wait group #20846

Merged
merged 5 commits into from
Apr 1, 2020
Merged

p2p/server: add UDP port mapping goroutine to wait group #20846

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c786a72
p2p/server | add some go routines to wg
ucwong Apr 1, 2020
a2af3d5
p2p/server : not deal with run peer goroutines in mainloop wg
ucwong Apr 1, 2020
f12380f
p2p/server : make sure slot release finally, but main loop wg
ucwong Apr 1, 2020
72a3777
p2p: remove defers
fjl Apr 1, 2020
b7e2867
p2p: fix whitespace
fjl Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion p2p/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,11 @@ func (srv *Server) setupDiscovery() error {
srv.log.Debug("UDP listener up", "addr", realaddr)
if srv.NAT != nil {
if !realaddr.IP.IsLoopback() {
go nat.Map(srv.NAT, srv.quit, "udp", realaddr.Port, realaddr.Port, "ethereum discovery")
srv.loopWG.Add(1)
go func() {
nat.Map(srv.NAT, srv.quit, "udp", realaddr.Port, realaddr.Port, "ethereum discovery")
srv.loopWG.Done()
}()
}
}
srv.localnode.SetFallbackUDP(realaddr.Port)
Expand Down