Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/downloader: remove eth62 #21378

Merged
merged 4 commits into from
Jul 29, 2020
Merged

eth/downloader: remove eth62 #21378

merged 4 commits into from
Jul 29, 2020

Conversation

renaynay
Copy link
Contributor

Resolves #20518

notes

removed some mentions of eth62, bumped protocol err too old to >=63
@renaynay renaynay marked this pull request as ready for review July 29, 2020 10:41
@renaynay renaynay changed the title [WIP] downloader: remove eth62 downloader: remove eth62 Jul 29, 2020
@fjl fjl changed the title downloader: remove eth62 eth/downloader: remove eth62 Jul 29, 2020
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.9.19 milestone Jul 29, 2020
@karalabe karalabe merged commit 1976bb3 into ethereum:master Jul 29, 2020
@renaynay renaynay deleted the remove-eth62 branch July 29, 2020 10:49
enriquefynn pushed a commit to enriquefynn/go-ethereum that referenced this pull request Mar 10, 2021
* init

notes

removed some mentions of eth62, bumped protocol err too old to >=63

* remove sanity checks and bump supported protocol version up to 63

* remove 62 tests, still need to add 65

* remove 65 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove eth62 notions from the downloader
2 participants