-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: move rlpx into separate package #21464
Merged
Merged
Commits on Sep 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8391793 - Browse repository at this point
Copy the full SHA 8391793View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd6c08d - Browse repository at this point
Copy the full SHA dd6c08dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0f9ca2 - Browse repository at this point
Copy the full SHA e0f9ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 962f3c9 - Browse repository at this point
Copy the full SHA 962f3c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 168fe15 - Browse repository at this point
Copy the full SHA 168fe15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43e582b - Browse repository at this point
Copy the full SHA 43e582bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3da471 - Browse repository at this point
Copy the full SHA d3da471View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d66cc - Browse repository at this point
Copy the full SHA 05d66ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7dfd7e - Browse repository at this point
Copy the full SHA b7dfd7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed018e - Browse repository at this point
Copy the full SHA 1ed018eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09445b5 - Browse repository at this point
Copy the full SHA 09445b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c959dd5 - Browse repository at this point
Copy the full SHA c959dd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a99dc52 - Browse repository at this point
Copy the full SHA a99dc52View commit details -
Configuration menu - View commit details
-
Copy full SHA for d088e57 - Browse repository at this point
Copy the full SHA d088e57View commit details -
p2p/rlpx: restore handshake tests and improve coverage
This restores the EIP-8 test and the frame format test vector. In order to make the latter test work, the code had to be restructured a bit, permitting an optimization: message frames are no longer allocated twice when decompressing. In ReadMsg, the compressed frame content was previously put into a bytes.Reader, then slurped up into a fresh []byte when decompressing.
Configuration menu - View commit details
-
Copy full SHA for 5b11f2e - Browse repository at this point
Copy the full SHA 5b11f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e233c39 - Browse repository at this point
Copy the full SHA e233c39View commit details -
p2p/rlpx: fix ignored error for invalid snappy encoding
Issue found by ineffassign
Configuration menu - View commit details
-
Copy full SHA for 0b1ab3a - Browse repository at this point
Copy the full SHA 0b1ab3aView commit details -
p2p: fix outdated comment about net.Pipe
net.Pipe supports deadlines since Go 1.10.
Configuration menu - View commit details
-
Copy full SHA for 65f1d36 - Browse repository at this point
Copy the full SHA 65f1d36View commit details
Commits on Sep 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 26fae4b - Browse repository at this point
Copy the full SHA 26fae4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3539d2 - Browse repository at this point
Copy the full SHA c3539d2View commit details -
It's useless now. Also return true size from Read to make metrics work.
Configuration menu - View commit details
-
Copy full SHA for 4caaa01 - Browse repository at this point
Copy the full SHA 4caaa01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 438094e - Browse repository at this point
Copy the full SHA 438094eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ce4fdb - Browse repository at this point
Copy the full SHA 8ce4fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd2fda5 - Browse repository at this point
Copy the full SHA fd2fda5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48867e - Browse repository at this point
Copy the full SHA f48867eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4cb3d9 - Browse repository at this point
Copy the full SHA f4cb3d9View commit details
Commits on Sep 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5cd9ace - Browse repository at this point
Copy the full SHA 5cd9aceView commit details -
p2p: remove dial destination identity check
This check is useless: the RLPx handshake works by encrypting the initial packet to the destination key. The recipient cannot decrypt this packet unless they have the matching private key. For dialed connections, the RLPx implementation simply returns the provided dial destination key as the remote identity, and we really don't need to check it one more time after the handshake.
Configuration menu - View commit details
-
Copy full SHA for 898a06b - Browse repository at this point
Copy the full SHA 898a06bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22ddc79 - Browse repository at this point
Copy the full SHA 22ddc79View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.