Remove uneeded syntax #21921
Merged
Remove uneeded syntax #21921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprut
requested review from
fjl,
holiman,
karalabe,
renaynay and
rjl493456442
as code owners
|
Given that this PR got out of sync already once, the benefit of keeping it in sync is less that the actual gains of this small syntactic sugar simplification changes. Would you mind reviewing @fjl @karalabe @holiman 🙏 . |
karalabe
reviewed
Jan 8, 2021
metrics/cpu_syscall.go
Outdated
| @@ -31,5 +31,5 @@ func getProcessCPUTime() int64 { | |||
| log.Warn("Failed to retrieve CPU time", "err", err) | |||
| return 0 | |||
| } | |||
| return int64(usage.Utime.Sec+usage.Stime.Sec)*100 + int64(usage.Utime.Usec+usage.Stime.Usec)/10000 //nolint:unconvert | |||
| return usage.Utime.Sec + usage.Stime.Sec*100 + int64(usage.Utime.Usec+usage.Stime.Usec)/10000 //nolint:unconvert | |||
There was a problem hiding this comment.
You messed up the math, parenthesis was needed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitpicky Small Changes