Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: fix issue with unmarshalling int32 into Long type #22153

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

renaynay
Copy link
Contributor

This PR fixes a graphql error with unmarshalling int32 into Long. This issue was noticed thanks to a graphql test failure on Hive (graphql_blocks_byFrom).

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why this fixes anything, but I'm fine with it if it seems to work :)

@renaynay
Copy link
Contributor Author

This PR fixes this error:

Screen Shot 2021-01-11 at 12 22 00 PM

Apparently there's an issue with specifying Long as a non-nullable field (with the !) that prevented unmarshalling int32 into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants