eth: move eth.Config to a common package #22205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
gballet,
holiman,
karalabe and
zsfelfoldi
as code owners
zsfelfoldi
approved these changes
Jan 21, 2021
|
Please fix the linter issue. |
gballet
reviewed
Jan 21, 2021
|
With this change, les still imports eth for |
|
@fjl I can also make the change here. I think the |
|
@fjl I think all the dependency from the les to eth has been resolved. Please take another look. |
fjl
changed the title
rjl493456442
force-pushed
the
move-eth-config
branch
from
dbc9324
to
e59a770
Compare
fjl
approved these changes
Feb 5, 2021
9 tasks
9 tasks
This was referenced Jun 17, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the eth config definition into a separate/common package. So that both ETh/LES protocol can only import this common package.