Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers: fix unigram tracer's return value #22248

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Jan 28, 2021

Fixes #22208. The issue is that the tracer doesn't return a value (i.e. in js-land it returns undefined) if a tx was transfer-only, and one transfer tx in the block was enough to make the whole call fail.

I'm not sure what's wrong with my go-bindata. I run go generate eth/tracers/internal/tracers/tracers.go but it changes the generated code by a bit.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except from the bindata. We use https://github.com/kevinburke/go-bindata, afaik

@holiman
Copy link
Contributor

holiman commented Jan 29, 2021

Yes, if you do make devtools, it downloads

go: downloading github.com/kevinburke/go-bindata v3.22.0+incompatible

So that's what's used on e.g. travis-builds.

@s1na
Copy link
Contributor Author

s1na commented Jan 29, 2021

Ah hadn't seen make devtools. I'm facing an error though, will have to investigate:

accounts/abi/bind/backend.go:24:2: import "github.com/ethereum/go-ethereum" is a program, not an importable package
make: *** [Makefile:53: devtools] Error 1

But for now I manually got the other go-bindata version and updated the PR.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 3c728fb into ethereum:master Feb 1, 2021
@holiman holiman added this to the 1.10.0 milestone Feb 1, 2021
@s1na s1na deleted the fix/traceBlockByNum branch February 1, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't call internal tracer in traceBlockByNumber
2 participants