-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p/dnsdisc: fix hot-spin when all trees are empty #22313
Merged
Merged
Commits on Feb 11, 2021
-
p2p/dnsdisc: fix hot-spin when all trees are empty
In the random sync algorithm used by the DNS node iterator, we first pick a random tree and then perform one sync action on that tree. This happens in a loop until any node is found. If no trees contain any nodes, the iterator would just keep starting over in a hot loop, spinning at 100% CPU. The fix is a bit complicated. The iterator now checks if any sync action can be performed on the tree before selecting it. If no action can be performed on any tree, it waits for the closest root record recheck time to arrive and then tries again.
Configuration menu - View commit details
-
Copy full SHA for 3ee8d93 - Browse repository at this point
Copy the full SHA 3ee8d93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a30f38 - Browse repository at this point
Copy the full SHA 1a30f38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21ce379 - Browse repository at this point
Copy the full SHA 21ce379View commit details -
Configuration menu - View commit details
-
Copy full SHA for e46d619 - Browse repository at this point
Copy the full SHA e46d619View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66cc151 - Browse repository at this point
Copy the full SHA 66cc151View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e211bc - Browse repository at this point
Copy the full SHA 6e211bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0d0029 - Browse repository at this point
Copy the full SHA e0d0029View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4b3b5b - Browse repository at this point
Copy the full SHA e4b3b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a9c66 - Browse repository at this point
Copy the full SHA b2a9c66View commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1278699 - Browse repository at this point
Copy the full SHA 1278699View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf03bb - Browse repository at this point
Copy the full SHA aaf03bbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.