trie: fix bloom crash on fast sync restart #22332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
If we roll back the chain to before the pivot block, that will reenable fast sync. However, the sync bloom filter is only allocated on startup. If we've just done an initial sync, and did
setHead
, it still works because the bloom is not nil, just closed. However if we've already synced and started the node with an existing chain, the bloom will benil
. Reenabling fast sync at that point crashes.This PR fixes it by having
trie.Sync
gracefully handle anil
bloom too, not just aclosed
bloom. It's fine not to rebuild the bloom in this case because we're probably only missing a few hundred trie nodes and it's not worth reading through the entire database and allocating gigabytes just to dedup a few hundred potential database reads.