-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: define and enable the Berlin hard fork on all networks #22380
Conversation
48d6b11
to
5eca033
Compare
LGTM, maybe with one little diff suggestion - would be good to remove as much yolov3 stuff as possible diff --git a/eth/tracers/api.go b/eth/tracers/api.go
index 013f5d52dd..cfb41a7ec3 100644
--- a/eth/tracers/api.go
+++ b/eth/tracers/api.go
@@ -585,8 +585,8 @@ func (api *API) standardTraceBlockToFile(ctx context.Context, block *types.Block
chainConfig.BerlinBlock = berlin
canon = false
}
- if yolov3 := config.LogConfig.Overrides.YoloV3Block; yolov3 != nil {
- chainConfig.YoloV3Block = yolov3
+ if berlin := config.LogConfig.Overrides.BerlinBlock; berlin != nil {
+ chainConfig.BerlinBlock = berlin
canon = false
}
} |
I did add Berlin too there just the lines above :P Not sure if I can nuke it given that it accesses Yolo directly. I'm happy to remove support for Yolo. Should we also drop it for Berlin? Any particular reason to have this override? |
Oops. |
Removed Yolov3 from there. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd/geth/config.go
Block number decisions: ethereum/pm#248 (comment)
Berlin hard fork details: https://github.com/ethereum/eth1.0-specs/blob/master/network-upgrades/berlin.md