Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/rawdb: fix the transaction indexer #22395

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Mar 1, 2021

This PR fixes an issue in the transaction indexer. The case is that: if there is NO transaction included in the unindexed blocks, so the database batch is empty. But in this case, the indexing tail should be updated anyway.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe added this to the 1.10.0 milestone Mar 1, 2021
@karalabe karalabe merged commit 19d7a37 into ethereum:master Mar 1, 2021
Copy link

@Platinumwrist Platinumwrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@Platinumwrist Platinumwrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core/rawdb/chain_iterator.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants