eth, les: fix tracer #22473
Merged
eth, les: fix tracer #22473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
karalabe
reviewed
Mar 11, 2021
karalabe
reviewed
Mar 11, 2021
karalabe
reviewed
Mar 11, 2021
karalabe
reviewed
Mar 11, 2021
holiman
reviewed
Mar 12, 2021
holiman
reviewed
Mar 12, 2021
karalabe
reviewed
Apr 7, 2021
eth/tracers/api.go
Outdated
| @@ -487,7 +488,7 @@ func (api *API) traceBlock(ctx context.Context, block *types.Block, config *Trac | |||
| if config != nil && config.Reexec != nil { | |||
| reexec = *config.Reexec | |||
| } | |||
| statedb, err := api.backend.StateAtBlock(ctx, parent, reexec, nil) | |||
| statedb, err := api.backend.StateAtBlock(ctx, parent, reexec, nil, false) | |||
There was a problem hiding this comment.
You want this and the others true :) Only traceChain should be false, shouldn't it?
karalabe
approved these changes
Apr 7, 2021
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
* eth, les: fix tracer * eth: isolate live trie database in tracer * eth: fix nil * eth: fix * eth, les: add checkLive param * eth/tracer: fix
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22469