Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cmd/utils: fix compilation issue on openbsd (#22511)" #22552

Conversation

gballet
Copy link
Member

@gballet gballet commented Mar 23, 2021

#22511 presented an incorrect fix and it was merged in haste. I am working on the correct fix in the background.

@karalabe
Copy link
Member

We were discussing that we should drop our custom disk space tracker altogether and just use gopsutils/disk. Doesn't make sense to reimplement something, especially if it's a pain to port.

@gballet
Copy link
Member Author

gballet commented Mar 23, 2021

agreed, the fix to gopsutil is in progress

@gballet
Copy link
Member Author

gballet commented Mar 23, 2021

btw the "fix" that was hastily merged didn't fix anything on master:

# github.com/shirou/gopsutil/mem
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:21:17: undefined: CTLVm
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:21:24: undefined: VmUvmexp
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:26:14: undefined: sizeOfUvmexp
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:29:13: undefined: Uvmexp
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:43:17: undefined: CTLVm
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:43:24: undefined: VmUvmexp
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:48:14: undefined: sizeOfUvmexp
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:51:13: undefined: Uvmexp
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:72:16: undefined: CTLVfs
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:72:24: undefined: VfsGeneric
../../../../pkg/mod/github.com/shirou/gopsutil@v2.20.5+incompatible/mem/mem_openbsd.go:72:24: too many errors

@holiman
Copy link
Contributor

holiman commented Mar 23, 2021

btw the "fix" that was hastily merged didn't fix anything on maste

Well, arguably it fixed an openbsd compilation error, but not all of them.

@fjl fjl closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants