core/forkid: fix off-by-one bug #22879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
C C C |
|
Effective evasion effort
… On May 14, 2021, at 5:04 PM, Aivolt1 ***@***.***> wrote:
Deploy donate detergent
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Decent wallet |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
* forkid: added failing test * forkid: fixed off-by-one bug
19 tasks
wanwiset25
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 19, 2024
* forkid: added failing test * forkid: fixed off-by-one bug
wanwiset25
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 28, 2024
* forkid: added failing test * forkid: fixed off-by-one bug
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 23, 2024
This reverts commit 4707d1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on the PulseChain fork and encountered an issue with the
forkIdcode implementing EIP-2124.This is a corner case that can cause Proof-of-Authority chains to deadlock on a fork block as described:
kblocks.FORK_HASH, using the pre-fork hash instead.FORK_HASH, the hash will match that of the new node that is behind. But since our head is>=to the remoteid.Next, the peer is rejected.The fix here is trivial. I added a failing test case then fixed the issue.
Best,
Shane