Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/all, internal/all: migrate to cli v2 #22948

Closed
wants to merge 1 commit into from
Closed

cmd/all, internal/all: migrate to cli v2 #22948

wants to merge 1 commit into from

Conversation

jn-lp
Copy link
Contributor

@jn-lp jn-lp commented May 26, 2021

The second version of the library brought us many new methods, interfaces and structures. The main innovations are new props in the context structure, default values for boolean flags and the IsSet method for flags. Improved overall performance and reduced memory usage for applications.

Further reading

Release notes: https://github.com/urfave/cli/releases/tag/v2.0.0
Migration guide: https://github.com/urfave/cli/blob/master/docs/migrate-v1-to-v2.md

@holiman
Copy link
Contributor

holiman commented May 26, 2021

Thanks,
This PR will require extensive testing. It might be worth trying to put together testcases of expected flag combinations and their effects, to better evaluate this change, and verify that the CLI interface remains unchanged (or at least have documentation on what parts changed). I'll think about how to best test this.

@holiman
Copy link
Contributor

holiman commented Apr 27, 2022

This PR is a bit bitrotted, so we'll probably just go with #24751 instead. Sorry, and thanks for the effort!

@holiman holiman closed this Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants