-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth/tracers: improve tracing performance #23016
Conversation
Further improvements:
Total:
|
I ran this against this transaction,
It took about |
So I tried this on a really heavy tx we have on ropsten This PR:
Current Master:
|
Looks like it worked then? Can the PR haz an approve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
18M gas on that transactions -- yeah might be a bit slow :) |
Improves the performance of debug.traceTransaction
* eth/tracers: improve tracing performance (ethereum#23016) Improves the performance of debug.traceTransaction * Update the import order Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: John.H <john.h@binance.com>
Improves the performance of debug.traceTransaction
This PR first adds a benchmark of the "opcode tracer", i.e, the barebones tracer which stores data in memory before sending it out over RPC. The benchmark is a very simple loop which just runs through
1M
gas.The second commit adds some optimizations which improves the performance quite a lot: