eth: drop eth/65, the last non-reqid protocol version #23120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested review from
holiman,
rjl493456442 and
zsfelfoldi
as code owners
|
I put this PR up on one of my NUCs: https://geth-bench.ethdevops.io/d/QC1Arp5Wk/single-geth?orgId=1&var-host=martin4&var-percentile=50&from=1625033586272&to=1625054083047 Switchover from 'normal' (but somewhat old) code to this PR about half time:
Strangely, the |
holiman
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally drops support for
eth/65as announced last year. It should only be merged after mainnet forks into London to maximize the life span for lagging clients. Also, this PR only drops serving the oldethprotocol, but followup PRs (or commits) are needed to clean up leftover assumptions in the fetcher/downloader and replace them with enforced request ids.