metrics/influxdb: Support V2 #23194
Merged
metrics/influxdb: Support V2 #23194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
changed the title
|
I can see that this seems to work by looking at the schemas created in Influx, and also seeing that Geth is successfully pushing data. However, I ran into issues connecting it to Grafana using the auth token. Tried adding the auth token via an http header as suggested in https://community.grafana.com/t/grafana-issue-connecting-to-influxdb-2-0-3-influxql/42757/4 . But that didn't work. I probably won't have too much free time to continue digging on that this week. But the issue doesn't seem relevant to this PR (only ensuring that it works as expected). |
karalabe
reviewed
Jul 13, 2021
karalabe
reviewed
Jul 13, 2021
jwasinger
force-pushed
the
influxdbv2
branch
2 times, most recently
from
ea6a7ff to
814912e
Compare
…casas' changes), leave existing support for v1 to maintain backwards-compatibility. Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com> Co-authored-by: Italo A. Casas <me@italoacasas.com>
|
Rebased on master so I can test it more easily |
|
Ok, tested this with a local node against our grafana/influxv1 (obs: version 1) cluster. Seems to work fine, in the sense that it doesn't break the old stuff. |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
…casas' changes), leave existing support for v1 to maintain backwards-compatibility. (ethereum#23194) This PR adds flag to enable InfluxDB v2 (--metrics.influxdbv2), flags for v2-specific features (--metrics.influxdb.token, --metrics.influxdb.bucket), also carries over addition of support for specifying organization (--metrics.influxdb.organization), but still retains backwards compatibility with InfluxDB v1.
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 10, 2024
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Dec 13, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 16, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 16, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 20, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 20, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Dec 22, 2024
JukLee0ira
pushed a commit
to JukLee0ira/XDPoSChain
that referenced
this pull request
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #22726:
* adds flag to enable v2 (
--metrics.influxdbv2), flags for v2-specific features (--metrics.influxdb.token,--metrics.influxdb.bucket), also carries over addition of support for specifying organization (--metrics.influxdb.organizationfrom #22726).* retains backwards compatibility with influxdb-v1.