core/bloombits: avoid crash when storing errors of different type #23437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherview
requested review from
holiman,
karalabe and
rjl493456442
as code owners
fjl
approved these changes
Aug 23, 2021
fjl
changed the title
|
Thanks for spotting this! |
sidhujag
pushed a commit
to sidhujag/go-ethereum
that referenced
this pull request
Aug 24, 2021
…hereum#23437) This fixes a rare crash which could occur when two different errors happened in the same bloombits.MatcherSession.
This was referenced Sep 23, 2022
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
…hereum#23437) This fixes a rare crash which could occur when two different errors happened in the same bloombits.MatcherSession.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
atomic.Valueit will panic if the error is a struct implementing the error interface and an error as been registered.From https://pkg.go.dev/sync/atomic#Value.Store,
Store sets the value of the Value to x. All calls to Store for a given Value must use values of the same concrete type. Store of an inconsistent type panics, as does Store(nil).Check this example. https://play.golang.org/p/N5Zp15o_AoE
We recently found this error at https://github.com/ava-labs/ when a custom error was returned from
rawdb.ReadBloomBits.Kudos to https://github.com/StephenButtolph for writing the code.