Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: support both input and data for personal_sendTransaction #23476

Merged
merged 1 commit into from
Aug 27, 2021
Merged

internal/ethapi: support both input and data for personal_sendTransaction #23476

merged 1 commit into from
Aug 27, 2021

Conversation

lightclient
Copy link
Member

Currently, setDefaults overwrites the transaction input value if only input is provided. This causes personal_sendTransaction to estimate the gas based on a transaction with empty data. eth_estimateGas never calls setDefaults so it was unaffected by this.

> params = { data: "0x6001", from: personal.listAccounts[0]  }
{
  data: "0x6001",
  from: "0xc0ffee61108b46c8b84c63df14e3a607ac981e93"
}
> personal.sendTransaction(params)
Error: intrinsic gas too low
        at web3.js:6347:37(47)
        at web3.js:5081:62(37)
        at <eval>:1:25(4)

holiman
holiman approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit ffae204 into ethereum:master Aug 27, 2021
@holiman holiman added this to the 1.10.9 milestone Aug 27, 2021
sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 27, 2021
@lightclient
internal/ethapi: support both input and data for personal_sendTransac…
2cd32b3 
…tion (ethereum#23476)

Currently, setDefaults overwrites the transaction input value if only input is provided. This causes personal_sendTransaction to estimate the gas based on a transaction with empty data. eth_estimateGas never calls setDefaults so it was unaffected by this.
This was referenced Sep 23, 2022
Closed
Merged
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@lightclient @zzyalbert
internal/ethapi: support both input and data for personal_sendTransac…
c89ad18 
…tion (ethereum#23476)

Currently, setDefaults overwrites the transaction input value if only input is provided. This causes personal_sendTransaction to estimate the gas based on a transaction with empty data. eth_estimateGas never calls setDefaults so it was unaffected by this.
@gzliudan gzliudan mentioned this pull request Jun 13, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 5, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
df2963e 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
7a461b7 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 1, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
085b46d 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 11, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
95efee0 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
2ce9f6b 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
2719c19 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
a8ea442 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
a3f7aec 
…tion (ethereum#23476)
JukLee0ira added a commit to JukLee0ira/XDPoSChain that referenced this pull request Aug 12, 2024
@JukLee0ira
internal/ethapi: support both input and data for personal_sendTransac…
f695ba7 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 12, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
d44fbf4 
…tion (ethereum#23476)
gzliudan pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 19, 2024
@JukLee0ira @gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
e19ede6 
…tion (ethereum#23476)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 19, 2024
@gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
155efb5 
…tion (ethereum#23476)
gzliudan pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 21, 2024
@JukLee0ira @gzliudan
internal/ethapi: support both input and data for personal_sendTransac…
925c200 
…tion (ethereum#23476)
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 23, 2024
@JukLee0ira @wanwiset25
internal/ethapi: support both input and data for personal_sendTransac…
2d9cf44 
…tion (ethereum#23476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.9
Development

Successfully merging this pull request may close these issues.
2 participants
@lightclient @holiman