rpc: set pong read deadline - Fixes #23528 #23556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2021
jmank88
force-pushed
the
severed-websocket
branch
from
729bcfd to
0111757
Compare
jmank88
changed the title
jmank88
changed the title
|
@holiman Is there anything else I can do here? |
|
Sorry, forgot, I'll revisit this
|
yongjun925
pushed a commit
to DODOEX/go-ethereum
that referenced
this pull request
Dec 3, 2022
This PR adds a 30s timeout for the remote part to answer a ping message, thus detecting (silent) disconnnects
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a (failing) test
TestClientWebsocketSevered, which demonstrates a hanging subscription after severing the client's websocket connection, as in #23528. The test times out after 3 ping intervals.The second commit fixes the test by adding a 30 second read timeout after each ping. This detects and discards severed connections after timing out, and subscriptions receive an error right away.
Fixes #23528