core/rawdb: implement freezer tail truncation #24027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
reviewed
Dec 2, 2021
| // Apply the table-offset | ||
| //from = from - t.itemOffset | ||
| for { | ||
| buffer := make([]byte, indexEntrySize) |
There was a problem hiding this comment.
looks like you forgot to bump the from?
There was a problem hiding this comment.
doh! well spotted!
I know there must be things like this lurking, since I haven't actually defined good testcases for it yet
| t.releaseFilesBefore(fileNo, false) | ||
| // In file corresponding to fileNo, we now need to delete all data prior to 'start' | ||
| destPath := t.fileName(int(fileNo)) | ||
| copyFrom(destPath, destPath, uint64(start)) |
There was a problem hiding this comment.
Since we truncate the data file first, a few corner cases need to be considered
e.g. if crash happens before we update the index file
- how to handle the items which are deleted from the data file but not from the index file yet(non-existent?)
- how to handle the items which are shifted in the tail data file but the relevant indexes are not updated yet(wrong item accessed with the original index?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP. More testcases are needed.
This PR implements tail truncation at arbitrary point, for individual freezer tables. It supersedes #23954 , which is mostly the same thing, the differences being:
This PR also fixes an issue with the head truncation -- the head truncation functionality on
masterfailed to take into account that a tail truncation might have been already performed, while calculating the indexes.