Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: set ttd override on all chain variations #24605

Merged
merged 1 commit into from
Mar 29, 2022
Merged

core: set ttd override on all chain variations #24605

merged 1 commit into from
Mar 29, 2022

Conversation

karalabe
Copy link
Member

No description provided.

MariusVanDerWijden
MariusVanDerWijden approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the logic slightly s.th. the compatibility is verified for the private networks too, which is good I think.
LGTM

@karalabe karalabe added this to the 1.10.17 milestone Mar 29, 2022
@karalabe karalabe merged commit 1027cb5 into ethereum:master Mar 29, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Apr 3, 2022
@karalabe
Merge pull request ethereum#24605 from karalabe/revert-setting-ttd
1681fd2 
core: set ttd override on all chain variations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
status:triage
Projects
None yet
Milestone
1.10.17
Development

Successfully merging this pull request may close these issues.
3 participants
@karalabe @holiman @MariusVanDerWijden