Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: use all APIs if rpc_module not found #25148

Closed
wants to merge 1 commit into from

Conversation

zacscoding
Copy link
Contributor

@zacscoding zacscoding commented Jun 22, 2022

Use all api modules if "rpc_module" not found for external api services (such as infura) in the console.
And added header flags for rpc client.

@fjl fjl self-assigned this Jun 28, 2022
- use all api modules if rpc_module not found
- adds header flags in the console
@holiman
Copy link
Contributor

holiman commented Oct 11, 2022

Custom headers has been implemented in #25829 .

@fjl fjl changed the title cmd/console: use all apis if rpc_module not found console: use all APIs if rpc_module not found Oct 11, 2022
@zacscoding
Copy link
Contributor Author

@holiman thx :) i will rebase commits

@holiman
Copy link
Contributor

holiman commented Nov 5, 2022

Hasn't been a lot of activity for the past three weeks. I'll close this, feel free to reopen if/when you rebase it.

@fjl
Copy link
Contributor

fjl commented Nov 28, 2022

The other half of this is now also in.

@fjl fjl removed their assignment Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants