Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus/beacon: don't ignore errors #25582

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Aug 23, 2022

This PR surfaces errors in two places where we previously ignored it.

@holiman holiman requested a review from karalabe as a code owner August 23, 2022 18:50
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe karalabe added this to the 1.10.23 milestone Aug 23, 2022
@karalabe karalabe merged commit 4c114af into ethereum:master Aug 23, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Aug 24, 2022
consensus/beacon: don't ignore errors
Copy link

@AlirezaDarbandi AlirezaDarbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consensus/beacon/consensus.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants