p2p/nat: set refreshInterval #26322
Closed
p2p/nat: set refreshInterval #26322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just saw #21390. I'll close this. |
|
Just note: According to RFC, The client SHOULD begin trying to renew the mapping halfway to expiry time, like DHCP. But renewal, expiration on lifetime does not work properly on some NAT devices(e.g. #21370 (comment)). Therefore, instead of keeping it through renewal, a new allocation method after expiration is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of refreshing the portmap is executed as a timer every lifetime, but it is not a refresh operation because the NAT mapping is deleted in the process of generating and transmitting the request packet. It's seems remapping. During this operation, there is a possibility that a node that was operating may not be able to communicate normally because another client preempts the port that was in use. PR is meant to prevent this.