Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/bootnode, cmd/utils: add 'pmp:<IP>' to --nat flag description #26381

Merged
merged 3 commits into from
Jan 16, 2023
Merged

cmd/bootnode, cmd/utils: add 'pmp:<IP>' to --nat flag description #26381

merged 3 commits into from
Jan 16, 2023

Commits on Dec 23, 2022

  1. squash 

    cmd/bootnode, p2p: use an alternate port mapped to NAT

* temp

* rede

* remove meaningless field

* temp comment

* set refresh time to param

* server: use channel enr.Entry

* server: rename `changedport` to `changeport`

* server: apply new nat-refresh `ethereum discovery`

* p2p/nat: add some comment

* p2p/nat: use `DefaultMapTimeout`

* p2p: fixed

* p2p/server: impr

* p2p/server: syntax change

* cmd/bootnode: add comments

* add p2p.Server changeport

* all: fix comments

* p2p/server: syntax changes

* cmd/bootnode: do not change UDPAddr Port

* p2p: remove incorrect `for` context

* p2p: add what needs to be addressed

* p2p/nat: use AddPortMapping if supported

* asynchronous port set

* remove unused variables

* change return format in `changePort`

* cmd/bootnode: consistent log

* p2p/server: rename `refreshLogger` to `newLogger`

* cmd/bootnode: fix incorrect if-else

* fix

* change log orders

* rename `natRefresh` to `natMapLoop`

* p2p: remove `changeport` in Server main loop

* server: remove duplicate code

* typo

* typo

* cmd/bootnode: consistent log message

* p2p: fix comments

test code about port change on localnode

cmd/bootnode: add log

improve test logic , add some comments

p2p/nat: add comments about not supported

p2p: remove unnecessary conversion in test
    @dbadoy
    dbadoy committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    9946032 View commit details
    Browse the repository at this point in the history

  2. Revert "squash" 

    This reverts commit 9946032.
    @dbadoy
    dbadoy committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    faeac3b View commit details
    Browse the repository at this point in the history

  3. add content in flag description

    @dbadoy
    dbadoy committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    cb983db View commit details
    Browse the repository at this point in the history