Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: implement withdrawals (EIP-4895) #26484

Merged
merged 43 commits into from
Jan 25, 2023
Merged

all: implement withdrawals (EIP-4895) #26484

merged 43 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. core/types: add withdrawal type

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    be4ad19 View commit details
    Browse the repository at this point in the history

  2. core/beacon: add withdrawals and make types version agnostic

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    72c91a4 View commit details
    Browse the repository at this point in the history

  3. eth/catalyst,les/catalyst: add withdrawals and make types version agn… 

    …ostic
    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1779e45 View commit details
    Browse the repository at this point in the history

  4. miner: add withdrawals and update catalyst types

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    79ed6d4 View commit details
    Browse the repository at this point in the history

  5. consensus: process withdrawals

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ed15060 View commit details
    Browse the repository at this point in the history

  6. core/state_processor: finalize with withdrawals

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    43ff685 View commit details
    Browse the repository at this point in the history

  7. core/chain_makers: add withdrawal support

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5e37321 View commit details
    Browse the repository at this point in the history

  8. core/block_validator: verify withdrawals root

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    cf34465 View commit details
    Browse the repository at this point in the history

  9. core/rawdb: update block readers with new block format

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e7170c2 View commit details
    Browse the repository at this point in the history

  10. eth: add p2p support for withdrawals

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    18a3ced View commit details
    Browse the repository at this point in the history

  11. cmd/evm: support withdrawals in t8n and b11r

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8c55bd6 View commit details
    Browse the repository at this point in the history

  12. eth/downloader: always use WithBody2 when constructing blocks 

    Co-authored-by: lightclient <lightclient@protonmail.com>
Co-authored-by: marioevz <marioevz@gmail.com>
    @lightclient @marioevz @MariusVanDerWijden
    2 people authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a6dd779 View commit details
    Browse the repository at this point in the history

  13. eth/fetcher: always use WithBody2 when constructing blocks

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f00089f View commit details
    Browse the repository at this point in the history

  14. params: core: enable shanghai based on timestamps

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    c66dc48 View commit details
    Browse the repository at this point in the history

  15. core,consensus: use timestamp based is shanghai check

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7c1651b View commit details
    Browse the repository at this point in the history

  16. consensus: fail if running shanghai on clique or ethash

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    218b71a View commit details
    Browse the repository at this point in the history

  17. core: set withdrawals hash in genesis, fix tests, add withdrawalRoot

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5c5cd11 View commit details
    Browse the repository at this point in the history

  18. all: implement forkid changes for shanghai

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    2e8233a View commit details
    Browse the repository at this point in the history

  19. core/types: make fetchers fetch withdrawals without transactions

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9c905c2 View commit details
    Browse the repository at this point in the history

  20. internal/ethapi: add withdrawals to full block

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5daaafe View commit details
    Browse the repository at this point in the history

  21. internal/ethapi: add comment

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f701ea4 View commit details
    Browse the repository at this point in the history

  22. miner: catalyst: return transaction fees for block

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    91b284e View commit details
    Browse the repository at this point in the history

  23. core/forkid: fix forkid filter

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    47b582d View commit details
    Browse the repository at this point in the history

  24. core/forkid: reduce diff by anonymous function

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a686276 View commit details
    Browse the repository at this point in the history

  25. core/beacon: correctly marshal block value

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    91b47e3 View commit details
    Browse the repository at this point in the history

  26. core: fix rebasing issues

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    101041a View commit details
    Browse the repository at this point in the history

  27. eth/protocols/eth: revert accidental modification

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    bac9e89 View commit details
    Browse the repository at this point in the history

  28. core, eth: use gwei for withdrawals

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    300f5f2 View commit details
    Browse the repository at this point in the history

  29. eth/catalyst: use gwei in test instead of hard coded value

    @lightclient @MariusVanDerWijden
    lightclient authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f959d38 View commit details
    Browse the repository at this point in the history

  30. core: fix nil panic

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    cf0ed02 View commit details
    Browse the repository at this point in the history

  31. all: fix review comments, add beacon.Faker, fix tests

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8c74d60 View commit details
    Browse the repository at this point in the history

  32. consensus/beacon: add faker

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    3263936 View commit details
    Browse the repository at this point in the history

  33. eth/catalyst: go generate, fix nitpicks

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1931e38 View commit details
    Browse the repository at this point in the history

  34. Update consensus/beacon/consensus.go

    @holiman @MariusVanDerWijden
    holiman authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    493741d View commit details
    Browse the repository at this point in the history

  35. Apply suggestions from code review

    @holiman @MariusVanDerWijden
    holiman authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    dd3c41a View commit details
    Browse the repository at this point in the history

  36. Update internal/ethapi/api.go

    @holiman @MariusVanDerWijden
    holiman authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7b073d1 View commit details
    Browse the repository at this point in the history

  37. Update core/types/block.go

    @holiman @MariusVanDerWijden
    holiman authored and MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    3481ebc View commit details
    Browse the repository at this point in the history

  38. all: rebase on uint64 timestamps

    @MariusVanDerWijden
    MariusVanDerWijden committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b43da37 View commit details
    Browse the repository at this point in the history

  39. consensus/beacon: add check for Shanghai activation in FinalizeAndAss… 

    …emble

Since this method returns an error, we can perform this check in the
engine instead of checking for Shanghai in callers of FinalizeAndAssemble.
    @fjl
    fjl committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f665111 View commit details
    Browse the repository at this point in the history

  40. core: remove Shanghai fork check in GenerateChain 

    This check is now performed by FinalizeAndAssemble.
    @fjl
    fjl committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    31a979c View commit details
    Browse the repository at this point in the history

  41. consensus/beacon: remove Shanghai fork check in Finalize 

    It is safe to apply withdrawals without checking for the fork because
the existence of withdrawals is a part of block validation.
    @fjl
    fjl committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8bdbf39 View commit details
    Browse the repository at this point in the history

  42. core: simplify withdrawals existence check in StateProcessor

    @fjl
    fjl committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8783b19 View commit details
    Browse the repository at this point in the history

  43. consensus/beacon: ensure correct empty withdrawals root in Shanghai b… 

    …locks
    @fjl
    fjl committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    428b0e6 View commit details
    Browse the repository at this point in the history