Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd,internal/era: implement
export-history
subcommand #26621cmd,internal/era: implement
export-history
subcommand #26621Changes from 27 commits
d017030
f3ec256
a9304e8
545f0b1
d58c913
76e08e0
d6cc601
6c4747f
97b86f4
b65db9d
ca3d8bf
cccf47b
7b9bda2
de45fca
235d413
1000755
008ed82
3fa17e7
02b3f19
b98b6d6
af6837f
64513d7
b8fc70e
67defc4
e9cb207
2a4cbda
0fa8947
beb6505
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to verify the withdrawals root in the future as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
era1
format is not intended to ever support withdrawals. We'll want to use the standardera
format currently exported by nimbus.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if I want to restore an archive node using these files in a post-4444 world, would I use .era1 files up to the merge and then .era files for merge up some post-weak subjectivity period checkpoint? Would this all be done on the EL, or would I import that .era files in my CL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It hasn't really been determined how the post-merge
era
files will be ingested. Two obvious paths:era
files and pushes payloads directly to EL.era
files and EL imports execution chain data from sameera
files.Obvious 1) seems preferred from a UX standpoint, but not sure it will be performant enough. Plus, some clients may opt to use
era
in-place as an ancient store. In which case you could just point both clients to the directory containing theera
files.