Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethdb/pebble: Fix MemTableStopWritesThreshold #26692

Merged
merged 3 commits into from
Feb 15, 2023
Merged

ethdb/pebble: Fix MemTableStopWritesThreshold #26692

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bab328
fix incorrect config
patrick-ogrady Feb 14, 2023
f14091c
revert newline change
patrick-ogrady Feb 14, 2023
6657f2e
revert linter changes
patrick-ogrady Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ethdb/pebble/pebble.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,13 @@ func New(file string, cache int, handles int, namespace string, readonly bool) (
handles = minHandles
}
logger := log.New("database", file)
logger.Info("Allocated cache and file handles", "cache", common.StorageSize(cache*1024*1024), "handles", handles)
logger.Info(
"Allocated cache and file handles",
"cache",
common.StorageSize(cache*1024*1024),
"handles",
handles,
)
patrick-ogrady marked this conversation as resolved.
Show resolved Hide resolved

// The max memtable size is limited by the uint32 offsets stored in
// internal/arenaskl.node, DeferredBatchOp, and flushableBatchEntry.
Expand Down Expand Up @@ -157,7 +163,10 @@ func New(file string, cache int, handles int, namespace string, readonly bool) (

// MemTableStopWritesThreshold places a hard limit on the size
// of the existent MemTables(including the frozen one).
MemTableStopWritesThreshold: memTableLimit * memTableSize,
// Note, this must be the number of tables not the size of all memtables
// according to https://github.com/cockroachdb/pebble/blob/master/options.go#L738-L742
// and to https://github.com/cockroachdb/pebble/blob/master/db.go#L1892-L1903.
MemTableStopWritesThreshold: memTableLimit,

// The default compaction concurrency(1 thread),
// Here use all available CPUs for faster compaction.
rjl493456442 marked this conversation as resolved.
Show resolved Hide resolved
Expand Down