core/state: move slot RLP encoding into the MPT implementation #27000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Apr 18, 2023
| v, _ = rlp.EncodeToBytes(common.TrimLeftZeroes(value[:])) | ||
| if err := tr.UpdateStorage(s.address, key[:], v); err != nil { | ||
| v, _ = rlp.EncodeToBytes(trimmedVal) | ||
| if err := tr.UpdateStorage(s.address, key[:], trimmedVal); err != nil { |
There was a problem hiding this comment.
Please change this to make it more obvious that v will be used for the snapshot later.
There was a problem hiding this comment.
For example, we could add a comment saying that.
There was a problem hiding this comment.
renamed it to snapshotVal and added a comment.
gballet
force-pushed
the
bring-rlp-inside-trie-iface
branch
from
9c8a06b to
d21aaf9
Compare
gballet
requested review from
zsfelfoldi,
rjl493456442,
karalabe and
holiman
as code owners
|
Need to test on the benchmarkers before we revisit it |
|
It has been running for a few days on bench07/08. No issue at first glance:
Slightly higher pressure on the GC: |
fjl
approved these changes
Jun 1, 2023
fjl
changed the title
rjl493456442
approved these changes
Jun 1, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#27000) Continuing with a series of PRs to make the Trie interface more generic, this PR moves the RLP encoding of storage slots inside the StateTrie and light.Trie implementations, as other types of tries don't use RLP.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
ethereum#27000)" This reverts commit 797c100.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
ethereum#27000)" This reverts commit 797c100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with a series of PRs to make the
Trieinterface more generic, this PR moves the RLP encoding of storage slots inside thesecure_trieandlight.Trieimplementations, as other types of tries don't use this.This PR is still in draft, as the snapshot still uses RLP. While I think the snapshot should also get rid of RLP, this would cause a bunch of issues:
Until a solution has been found, this means the RLP decoding happens twice for a snapshot-enabled MPT client.