Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: use embed for graphql ui html #27282

Closed
wants to merge 2 commits into from
Closed

graphql: use embed for graphql ui html #27282

wants to merge 2 commits into from

Conversation

islishude
Copy link
Contributor

I also downgrade fetch to v2 due to JakeChampion/fetch#656

image image

@islishude islishude requested a review from s1na as a code owner May 16, 2023 14:06
graphql/graphql.html Outdated Show resolved Hide resolved
@holiman
Copy link
Contributor

holiman commented May 17, 2023

I also downgrade fetch to v2 due to JakeChampion/fetch#656

That is an old ticket from 2018, from what I can tell it has something to do with IE11. Is it still relevant? Is it a problem that you encountered while using the graphql page?
Curious, since as far as I know, nobody has filed a ticket about it at go-ethereum.

@islishude
Copy link
Contributor Author

Curious, since as far as I know, nobody has filed a ticket about it at go-ethereum.

because the fetch library is just a polyfill. and since 2017 all mainstream browsers have supported fetch. so even if the library has an error, it does not affect normal use.

imo, it can be removed now.

fyi, https://caniuse.com/?search=fetch

@s1na
Copy link
Contributor

s1na commented May 17, 2023

Can you please try this #27294 and see if you get the error there also?

@islishude
Copy link
Contributor Author

Can you please try this #27294 and see if you get the error there also?

it doesn't use fetch polyfill

@holiman
Copy link
Contributor

holiman commented May 19, 2023

Closing in favour of #27294

@holiman holiman closed this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants